Re: [PATCH 07/14] efi: runtime-wrappers: Run UEFI Runtime Services with interrupts enabled

2016-02-03 Thread Matt Fleming
On Wed, 03 Feb, at 12:33:10PM, Ard Biesheuvel wrote: > On 3 February 2016 at 11:58, Ingo Molnar wrote: > > > > * Ard Biesheuvel wrote: > > > >> > More fundamentally, this makes me nervous: > >> > > >> > > The UEFI spec allows Runtime Services to be invoked with interrupts > >> > > enabled.

Re: [PATCH 07/14] efi: runtime-wrappers: Run UEFI Runtime Services with interrupts enabled

2016-02-03 Thread Ard Biesheuvel
On 3 February 2016 at 11:58, Ingo Molnar wrote: > > * Ard Biesheuvel wrote: > >> > More fundamentally, this makes me nervous: >> > >> > > The UEFI spec allows Runtime Services to be invoked with interrupts >> > > enabled. [...] >> > >> > So what really matters is not what the spec says, but

Re: [PATCH 07/14] efi: runtime-wrappers: Run UEFI Runtime Services with interrupts enabled

2016-02-03 Thread Ingo Molnar
* Ard Biesheuvel wrote: > > More fundamentally, this makes me nervous: > > > > > The UEFI spec allows Runtime Services to be invoked with interrupts > > > enabled. [...] > > > > So what really matters is not what the spec says, but how Windows executes > > UEFI firmware code in practice. >

Re: [PATCH 07/14] efi: runtime-wrappers: Run UEFI Runtime Services with interrupts enabled

2016-02-03 Thread Ard Biesheuvel
On 3 February 2016 at 10:43, Ingo Molnar wrote: > > * Matt Fleming wrote: > >> From: Ard Biesheuvel >> >> The UEFI spec allows Runtime Services to be invoked with interrupts >> enabled. The only reason we were disabling interrupts was to prevent >> recursive calls into the services on the same

Re: [PATCH 07/14] efi: runtime-wrappers: Run UEFI Runtime Services with interrupts enabled

2016-02-03 Thread Ingo Molnar
* Matt Fleming wrote: > From: Ard Biesheuvel > > The UEFI spec allows Runtime Services to be invoked with interrupts > enabled. The only reason we were disabling interrupts was to prevent > recursive calls into the services on the same CPU, which will lead to > deadlock. However, the only

Re: [PATCH 07/14] efi: runtime-wrappers: Run UEFI Runtime Services with interrupts enabled

2016-02-03 Thread Ingo Molnar
* Matt Fleming wrote: > From: Ard Biesheuvel > > The UEFI spec allows Runtime Services to be invoked with interrupts > enabled. The only reason we were disabling interrupts was to prevent > recursive calls into the services on the same CPU,

Re: [PATCH 07/14] efi: runtime-wrappers: Run UEFI Runtime Services with interrupts enabled

2016-02-03 Thread Ard Biesheuvel
On 3 February 2016 at 11:58, Ingo Molnar wrote: > > * Ard Biesheuvel wrote: > >> > More fundamentally, this makes me nervous: >> > >> > > The UEFI spec allows Runtime Services to be invoked with interrupts >> > > enabled. [...] >> > >> > So what

Re: [PATCH 07/14] efi: runtime-wrappers: Run UEFI Runtime Services with interrupts enabled

2016-02-03 Thread Ard Biesheuvel
On 3 February 2016 at 10:43, Ingo Molnar wrote: > > * Matt Fleming wrote: > >> From: Ard Biesheuvel >> >> The UEFI spec allows Runtime Services to be invoked with interrupts >> enabled. The only reason we were disabling

Re: [PATCH 07/14] efi: runtime-wrappers: Run UEFI Runtime Services with interrupts enabled

2016-02-03 Thread Ingo Molnar
* Ard Biesheuvel wrote: > > More fundamentally, this makes me nervous: > > > > > The UEFI spec allows Runtime Services to be invoked with interrupts > > > enabled. [...] > > > > So what really matters is not what the spec says, but how Windows executes > > UEFI

Re: [PATCH 07/14] efi: runtime-wrappers: Run UEFI Runtime Services with interrupts enabled

2016-02-03 Thread Matt Fleming
On Wed, 03 Feb, at 12:33:10PM, Ard Biesheuvel wrote: > On 3 February 2016 at 11:58, Ingo Molnar wrote: > > > > * Ard Biesheuvel wrote: > > > >> > More fundamentally, this makes me nervous: > >> > > >> > > The UEFI spec allows Runtime Services to be

[PATCH 07/14] efi: runtime-wrappers: Run UEFI Runtime Services with interrupts enabled

2016-02-01 Thread Matt Fleming
From: Ard Biesheuvel The UEFI spec allows Runtime Services to be invoked with interrupts enabled. The only reason we were disabling interrupts was to prevent recursive calls into the services on the same CPU, which will lead to deadlock. However, the only context where such invocations may occur

[PATCH 07/14] efi: runtime-wrappers: Run UEFI Runtime Services with interrupts enabled

2016-02-01 Thread Matt Fleming
From: Ard Biesheuvel The UEFI spec allows Runtime Services to be invoked with interrupts enabled. The only reason we were disabling interrupts was to prevent recursive calls into the services on the same CPU, which will lead to deadlock. However, the only context where