Re: [PATCH 07/17] new helpers: skb_copy_datagram_from_iter() and zerocopy_sg_from_iter()

2014-11-24 Thread Al Viro
On Mon, Nov 24, 2014 at 01:34:30PM +0800, Jason Wang wrote: > >> + copied = iov_iter_get_pages(from, pages, ~0U, MAX_SKB_FRAGS, > >> ); > > Why is this condition needed, given we told iov_iter_get_pages() to > > limit to MAX_SKB_FRAGS pages? > > We don't want to send truncated packets

Re: [PATCH 07/17] new helpers: skb_copy_datagram_from_iter() and zerocopy_sg_from_iter()

2014-11-24 Thread Al Viro
On Mon, Nov 24, 2014 at 01:34:30PM +0800, Jason Wang wrote: + copied = iov_iter_get_pages(from, pages, ~0U, MAX_SKB_FRAGS, start); Why is this condition needed, given we told iov_iter_get_pages() to limit to MAX_SKB_FRAGS pages? We don't want to send truncated packets and

Re: [PATCH 07/17] new helpers: skb_copy_datagram_from_iter() and zerocopy_sg_from_iter()

2014-11-23 Thread Jason Wang
On 11/24/2014 08:02 AM, Ben Hutchings wrote: > On Sat, 2014-11-22 at 04:33 +, Al Viro wrote: > [...] >> --- a/net/core/datagram.c >> +++ b/net/core/datagram.c >> @@ -572,6 +572,77 @@ fault: >> } >> EXPORT_SYMBOL(skb_copy_datagram_from_iovec); >> > Missing kernel-doc. > >> +int

Re: [PATCH 07/17] new helpers: skb_copy_datagram_from_iter() and zerocopy_sg_from_iter()

2014-11-23 Thread Ben Hutchings
On Mon, 2014-11-24 at 00:02 +, Ben Hutchings wrote: > On Sat, 2014-11-22 at 04:33 +, Al Viro wrote: > [...] > > --- a/net/core/datagram.c > > +++ b/net/core/datagram.c > > @@ -572,6 +572,77 @@ fault: > > } > > EXPORT_SYMBOL(skb_copy_datagram_from_iovec); > > > > Missing kernel-doc.

Re: [PATCH 07/17] new helpers: skb_copy_datagram_from_iter() and zerocopy_sg_from_iter()

2014-11-23 Thread Ben Hutchings
On Sat, 2014-11-22 at 04:33 +, Al Viro wrote: [...] > --- a/net/core/datagram.c > +++ b/net/core/datagram.c > @@ -572,6 +572,77 @@ fault: > } > EXPORT_SYMBOL(skb_copy_datagram_from_iovec); > Missing kernel-doc. > +int skb_copy_datagram_from_iter(struct sk_buff *skb, int offset, > +

Re: [PATCH 07/17] new helpers: skb_copy_datagram_from_iter() and zerocopy_sg_from_iter()

2014-11-23 Thread Ben Hutchings
On Sat, 2014-11-22 at 04:33 +, Al Viro wrote: [...] --- a/net/core/datagram.c +++ b/net/core/datagram.c @@ -572,6 +572,77 @@ fault: } EXPORT_SYMBOL(skb_copy_datagram_from_iovec); Missing kernel-doc. +int skb_copy_datagram_from_iter(struct sk_buff *skb, int offset, +

Re: [PATCH 07/17] new helpers: skb_copy_datagram_from_iter() and zerocopy_sg_from_iter()

2014-11-23 Thread Ben Hutchings
On Mon, 2014-11-24 at 00:02 +, Ben Hutchings wrote: On Sat, 2014-11-22 at 04:33 +, Al Viro wrote: [...] --- a/net/core/datagram.c +++ b/net/core/datagram.c @@ -572,6 +572,77 @@ fault: } EXPORT_SYMBOL(skb_copy_datagram_from_iovec); Missing kernel-doc. [...] Never mind,

Re: [PATCH 07/17] new helpers: skb_copy_datagram_from_iter() and zerocopy_sg_from_iter()

2014-11-23 Thread Jason Wang
On 11/24/2014 08:02 AM, Ben Hutchings wrote: On Sat, 2014-11-22 at 04:33 +, Al Viro wrote: [...] --- a/net/core/datagram.c +++ b/net/core/datagram.c @@ -572,6 +572,77 @@ fault: } EXPORT_SYMBOL(skb_copy_datagram_from_iovec); Missing kernel-doc. +int

[PATCH 07/17] new helpers: skb_copy_datagram_from_iter() and zerocopy_sg_from_iter()

2014-11-21 Thread Al Viro
Signed-off-by: Al Viro --- include/linux/skbuff.h |3 ++ net/core/datagram.c| 115 2 files changed, 118 insertions(+) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 18ce42e..ce69d48 100644 --- a/include/linux/skbuff.h

[PATCH 07/17] new helpers: skb_copy_datagram_from_iter() and zerocopy_sg_from_iter()

2014-11-21 Thread Al Viro
Signed-off-by: Al Viro v...@zeniv.linux.org.uk --- include/linux/skbuff.h |3 ++ net/core/datagram.c| 115 2 files changed, 118 insertions(+) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 18ce42e..ce69d48 100644 ---