Re: [PATCH 08/10] PCI: dwc: artpec6: add support for endpoint mode

2017-10-20 Thread Niklas Cassel
On 10/18/2017 10:46 AM, Kishon Vijay Abraham I wrote: > Hi Niklas, > > On Friday 13 October 2017 09:39 PM, Niklas Cassel wrote: >> Signed-off-by: Niklas Cassel >> --- >> .../devicetree/bindings/pci/axis,artpec6-pcie.txt | 3 +- >> drivers/pci/dwc/Kconfig| 41 +++--

Re: [PATCH 08/10] PCI: dwc: artpec6: add support for endpoint mode

2017-10-19 Thread Niklas Cassel
Hello Bjorn On 10/17/2017 01:43 AM, Bjorn Helgaas wrote: (snip) > I see you're copying the DRA7XX style here, but I don't really > understand it. I guess the idea is to build pcie-artpec6.o if either > CONFIG_PCIE_ARTPEC6_HOST or CONFIG_PCIE_ARTPEC6_EP is set (or both). > > Is this really the si

Re: [PATCH 08/10] PCI: dwc: artpec6: add support for endpoint mode

2017-10-19 Thread Niklas Cassel
On 10/19/2017 09:59 AM, Christoph Hellwig wrote: > On Mon, Oct 16, 2017 at 06:43:26PM -0500, Bjorn Helgaas wrote: >> understand it. I guess the idea is to build pcie-artpec6.o if either >> CONFIG_PCIE_ARTPEC6_HOST or CONFIG_PCIE_ARTPEC6_EP is set (or both). >> >> Is this really the simplest way to

Re: [PATCH 08/10] PCI: dwc: artpec6: add support for endpoint mode

2017-10-19 Thread Christoph Hellwig
On Mon, Oct 16, 2017 at 06:43:26PM -0500, Bjorn Helgaas wrote: > understand it. I guess the idea is to build pcie-artpec6.o if either > CONFIG_PCIE_ARTPEC6_HOST or CONFIG_PCIE_ARTPEC6_EP is set (or both). > > Is this really the simplest way to express that in Kconfig? Both the > "if PCIE_ARTPEC6

Re: [PATCH 08/10] PCI: dwc: artpec6: add support for endpoint mode

2017-10-18 Thread Kishon Vijay Abraham I
Niklas, On Wednesday 18 October 2017 01:45 PM, Niklas Cassel wrote: > On 10/18/2017 10:03 AM, Kishon Vijay Abraham I wrote: >> Hi Bjorn, >> >> On Tuesday 17 October 2017 05:13 AM, Bjorn Helgaas wrote: >>> On Fri, Oct 13, 2017 at 06:09:11PM +0200, Niklas Cassel wrote: Signed-off-by: Niklas Cas

Re: [PATCH 08/10] PCI: dwc: artpec6: add support for endpoint mode

2017-10-18 Thread Kishon Vijay Abraham I
Hi Niklas, On Friday 13 October 2017 09:39 PM, Niklas Cassel wrote: > Signed-off-by: Niklas Cassel > --- > .../devicetree/bindings/pci/axis,artpec6-pcie.txt | 3 +- > drivers/pci/dwc/Kconfig| 41 +++-- > drivers/pci/dwc/Makefile | 4 +-

Re: [PATCH 08/10] PCI: dwc: artpec6: add support for endpoint mode

2017-10-18 Thread Niklas Cassel
On 10/18/2017 10:03 AM, Kishon Vijay Abraham I wrote: > Hi Bjorn, > > On Tuesday 17 October 2017 05:13 AM, Bjorn Helgaas wrote: >> On Fri, Oct 13, 2017 at 06:09:11PM +0200, Niklas Cassel wrote: >>> Signed-off-by: Niklas Cassel >>> --- >>> .../devicetree/bindings/pci/axis,artpec6-pcie.txt | 3

Re: [PATCH 08/10] PCI: dwc: artpec6: add support for endpoint mode

2017-10-18 Thread Kishon Vijay Abraham I
Hi Bjorn, On Tuesday 17 October 2017 05:13 AM, Bjorn Helgaas wrote: > On Fri, Oct 13, 2017 at 06:09:11PM +0200, Niklas Cassel wrote: >> Signed-off-by: Niklas Cassel >> --- >> .../devicetree/bindings/pci/axis,artpec6-pcie.txt | 3 +- >> drivers/pci/dwc/Kconfig| 41

Re: [PATCH 08/10] PCI: dwc: artpec6: add support for endpoint mode

2017-10-17 Thread Rob Herring
On Fri, Oct 13, 2017 at 06:09:11PM +0200, Niklas Cassel wrote: > Signed-off-by: Niklas Cassel > --- > .../devicetree/bindings/pci/axis,artpec6-pcie.txt | 3 +- It is preferred to split binding patches. Regardless, Acked-by: Rob Herring > drivers/pci/dwc/Kconfig|

Re: [PATCH 08/10] PCI: dwc: artpec6: add support for endpoint mode

2017-10-16 Thread Bjorn Helgaas
On Fri, Oct 13, 2017 at 06:09:11PM +0200, Niklas Cassel wrote: > Signed-off-by: Niklas Cassel > --- > .../devicetree/bindings/pci/axis,artpec6-pcie.txt | 3 +- > drivers/pci/dwc/Kconfig| 41 +++-- > drivers/pci/dwc/Makefile | 4 +- > dri

[PATCH 08/10] PCI: dwc: artpec6: add support for endpoint mode

2017-10-13 Thread Niklas Cassel
Signed-off-by: Niklas Cassel --- .../devicetree/bindings/pci/axis,artpec6-pcie.txt | 3 +- drivers/pci/dwc/Kconfig| 41 +++-- drivers/pci/dwc/Makefile | 4 +- drivers/pci/dwc/pcie-artpec6.c | 202 -