Re: [PATCH 08/13] net/ipv4/tcp_input.c: kill off ACCESS_ONCE()

2017-10-09 Thread Mark Rutland
On Mon, Oct 09, 2017 at 07:28:45PM +0100, Mark Rutland wrote: > - ACCESS_ONCE(sk->sk_pacing_rate) = min_t(u64, rate, > - sk->sk_max_pacing_rate); > + WRITE_ONCE(sk->sk_pacing_rate) = min_t(u64, rate, > +

Re: [PATCH 08/13] net/ipv4/tcp_input.c: kill off ACCESS_ONCE()

2017-10-09 Thread Mark Rutland
On Mon, Oct 09, 2017 at 07:28:45PM +0100, Mark Rutland wrote: > - ACCESS_ONCE(sk->sk_pacing_rate) = min_t(u64, rate, > - sk->sk_max_pacing_rate); > + WRITE_ONCE(sk->sk_pacing_rate) = min_t(u64, rate, > +

[PATCH 08/13] net/ipv4/tcp_input.c: kill off ACCESS_ONCE()

2017-10-09 Thread Mark Rutland
For several reasons, it is desirable to use {READ,WRITE}_ONCE() in preference to ACCESS_ONCE(), and new code is expected to use one of the former. So far, there's been no reason to change most existing uses of ACCESS_ONCE(), as these aren't currently harmful. However, for some features it is

[PATCH 08/13] net/ipv4/tcp_input.c: kill off ACCESS_ONCE()

2017-10-09 Thread Mark Rutland
For several reasons, it is desirable to use {READ,WRITE}_ONCE() in preference to ACCESS_ONCE(), and new code is expected to use one of the former. So far, there's been no reason to change most existing uses of ACCESS_ONCE(), as these aren't currently harmful. However, for some features it is