Re: [PATCH 08/15] powerpc/powernv: implement opal_put_chars_atomic

2018-05-07 Thread Nicholas Piggin
On Mon, 07 May 2018 20:35:42 +1000 Michael Ellerman wrote: > Nicholas Piggin writes: > > > On Tue, 01 May 2018 19:48:58 +1000 > > Benjamin Herrenschmidt wrote: > > > >> On Tue, 2018-05-01 at 00:55 +1000, Nicholas Piggin

Re: [PATCH 08/15] powerpc/powernv: implement opal_put_chars_atomic

2018-05-07 Thread Nicholas Piggin
On Mon, 07 May 2018 20:35:42 +1000 Michael Ellerman wrote: > Nicholas Piggin writes: > > > On Tue, 01 May 2018 19:48:58 +1000 > > Benjamin Herrenschmidt wrote: > > > >> On Tue, 2018-05-01 at 00:55 +1000, Nicholas Piggin wrote: > >> > The RAW console does not need writes to be atomic, so

Re: [PATCH 08/15] powerpc/powernv: implement opal_put_chars_atomic

2018-05-07 Thread Michael Ellerman
Nicholas Piggin writes: > On Tue, 01 May 2018 19:48:58 +1000 > Benjamin Herrenschmidt wrote: > >> On Tue, 2018-05-01 at 00:55 +1000, Nicholas Piggin wrote: >> > The RAW console does not need writes to be atomic, so relax >> > opal_put_chars to be

Re: [PATCH 08/15] powerpc/powernv: implement opal_put_chars_atomic

2018-05-07 Thread Michael Ellerman
Nicholas Piggin writes: > On Tue, 01 May 2018 19:48:58 +1000 > Benjamin Herrenschmidt wrote: > >> On Tue, 2018-05-01 at 00:55 +1000, Nicholas Piggin wrote: >> > The RAW console does not need writes to be atomic, so relax >> > opal_put_chars to be able to do partial writes, and implement an >> >

Re: [PATCH 08/15] powerpc/powernv: implement opal_put_chars_atomic

2018-05-01 Thread Nicholas Piggin
On Tue, 01 May 2018 19:48:58 +1000 Benjamin Herrenschmidt wrote: > On Tue, 2018-05-01 at 00:55 +1000, Nicholas Piggin wrote: > > The RAW console does not need writes to be atomic, so relax > > opal_put_chars to be able to do partial writes, and implement an > > _atomic

Re: [PATCH 08/15] powerpc/powernv: implement opal_put_chars_atomic

2018-05-01 Thread Nicholas Piggin
On Tue, 01 May 2018 19:48:58 +1000 Benjamin Herrenschmidt wrote: > On Tue, 2018-05-01 at 00:55 +1000, Nicholas Piggin wrote: > > The RAW console does not need writes to be atomic, so relax > > opal_put_chars to be able to do partial writes, and implement an > > _atomic variant which does not

Re: [PATCH 08/15] powerpc/powernv: implement opal_put_chars_atomic

2018-05-01 Thread Benjamin Herrenschmidt
On Tue, 2018-05-01 at 00:55 +1000, Nicholas Piggin wrote: > The RAW console does not need writes to be atomic, so relax > opal_put_chars to be able to do partial writes, and implement an > _atomic variant which does not take a spinlock. This API is used > in xmon, so the less locking that is used,

Re: [PATCH 08/15] powerpc/powernv: implement opal_put_chars_atomic

2018-05-01 Thread Benjamin Herrenschmidt
On Tue, 2018-05-01 at 00:55 +1000, Nicholas Piggin wrote: > The RAW console does not need writes to be atomic, so relax > opal_put_chars to be able to do partial writes, and implement an > _atomic variant which does not take a spinlock. This API is used > in xmon, so the less locking that is used,

[PATCH 08/15] powerpc/powernv: implement opal_put_chars_atomic

2018-04-30 Thread Nicholas Piggin
The RAW console does not need writes to be atomic, so relax opal_put_chars to be able to do partial writes, and implement an _atomic variant which does not take a spinlock. This API is used in xmon, so the less locking that is used, the better chance there is that a crash can be debugged. Cc:

[PATCH 08/15] powerpc/powernv: implement opal_put_chars_atomic

2018-04-30 Thread Nicholas Piggin
The RAW console does not need writes to be atomic, so relax opal_put_chars to be able to do partial writes, and implement an _atomic variant which does not take a spinlock. This API is used in xmon, so the less locking that is used, the better chance there is that a crash can be debugged. Cc: