Re: [PATCH 08/16] x86, asmlinkage, kexec: Drop bogus asmlinkage in machine_kexec_32

2013-08-05 Thread Andi Kleen
On Mon, Aug 05, 2013 at 04:03:27PM -0700, H. Peter Anvin wrote: > On 08/05/2013 03:02 PM, Andi Kleen wrote: > > From: Andi Kleen > > > > A function pointer cannot be asmlinkage. Just drop it. > > > > Signed-off-by: Andi Kleen > > Eh? It certainly matters for the function pointer if it is regp

Re: [PATCH 08/16] x86, asmlinkage, kexec: Drop bogus asmlinkage in machine_kexec_32

2013-08-05 Thread H. Peter Anvin
On 08/05/2013 03:02 PM, Andi Kleen wrote: > From: Andi Kleen > > A function pointer cannot be asmlinkage. Just drop it. > > Signed-off-by: Andi Kleen Eh? It certainly matters for the function pointer if it is regparm(0) or regparm(3), and the pointed-to function definitely assumes regparm(0).

[PATCH 08/16] x86, asmlinkage, kexec: Drop bogus asmlinkage in machine_kexec_32

2013-08-05 Thread Andi Kleen
From: Andi Kleen A function pointer cannot be asmlinkage. Just drop it. Signed-off-by: Andi Kleen --- arch/x86/kernel/machine_kexec_32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/machine_kexec_32.c b/arch/x86/kernel/machine_kexec_32.c index 5b19e4d..7