Re: [PATCH 09/10] lib traceeevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

2018-01-12 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 11, 2018 at 08:14:35PM -0500, Steven Rostedt escreveu: > On Fri, 12 Jan 2018 10:00:34 +0900 > Taeung Song wrote: > > > Hi Steven, > > > > I found a trivial typo "eee" on the commit log title > > That traceevent got too close to a nuclear power plant. > > >

Re: [PATCH 09/10] lib traceeevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

2018-01-12 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 11, 2018 at 08:14:35PM -0500, Steven Rostedt escreveu: > On Fri, 12 Jan 2018 10:00:34 +0900 > Taeung Song wrote: > > > Hi Steven, > > > > I found a trivial typo "eee" on the commit log title > > That traceevent got too close to a nuclear power plant. > > > It seems better to

Re: [PATCH 09/10] lib traceeevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

2018-01-11 Thread Steven Rostedt
On Fri, 12 Jan 2018 10:00:34 +0900 Taeung Song wrote: > Hi Steven, > > I found a trivial typo "eee" on the commit log title That traceevent got too close to a nuclear power plant. > It seems better to change "lib traceeevent" to " lib traceevent", > if you want to do

Re: [PATCH 09/10] lib traceeevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

2018-01-11 Thread Steven Rostedt
On Fri, 12 Jan 2018 10:00:34 +0900 Taeung Song wrote: > Hi Steven, > > I found a trivial typo "eee" on the commit log title That traceevent got too close to a nuclear power plant. > It seems better to change "lib traceeevent" to " lib traceevent", > if you want to do it.. Yeah it should be

Re: [PATCH 09/10] lib traceeevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

2018-01-11 Thread Taeung Song
Hi Steven, I found a trivial typo "eee" on the commit log title It seems better to change "lib traceeevent" to " lib traceevent", if you want to do it.. Thanks, Taeung On 01/12/2018 09:47 AM, Steven Rostedt wrote:

Re: [PATCH 09/10] lib traceeevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

2018-01-11 Thread Taeung Song
Hi Steven, I found a trivial typo "eee" on the commit log title It seems better to change "lib traceeevent" to " lib traceevent", if you want to do it.. Thanks, Taeung On 01/12/2018 09:47 AM, Steven Rostedt wrote:

[PATCH 09/10] lib traceeevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

2018-01-11 Thread Steven Rostedt
From: Taeung Song Currently the FILTER_TRIVIAL_FALSE case has a missing break statement, if the trivial type is FALSE, it will also run into the TRUE case, and always be skipped as the TRUE statement will continue the loop on the inverse condition of the FALSE statement.

[PATCH 09/10] lib traceeevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

2018-01-11 Thread Steven Rostedt
From: Taeung Song Currently the FILTER_TRIVIAL_FALSE case has a missing break statement, if the trivial type is FALSE, it will also run into the TRUE case, and always be skipped as the TRUE statement will continue the loop on the inverse condition of the FALSE statement. Link: