Re: [PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU

2020-08-31 Thread Ulf Hansson
On Sat, 29 Aug 2020 at 10:31, Christoph Hellwig wrote: > > On Fri, Aug 28, 2020 at 11:09:43AM -0400, Rich Felker wrote: > > > However, by looking at the code, one get the feeling that the DMA > > > support is somewhat prepared to be made optional. I guess it has never > > > been really tested, as

Re: [PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU

2020-08-29 Thread Christoph Hellwig
On Fri, Aug 28, 2020 at 11:09:43AM -0400, Rich Felker wrote: > > However, by looking at the code, one get the feeling that the DMA > > support is somewhat prepared to be made optional. I guess it has never > > been really tested, as the Kconfig option has "depends on HAS_DMA" - > > and it's been

Re: [PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU

2020-08-28 Thread Rich Felker
On Fri, Aug 28, 2020 at 11:26:57AM +0200, Ulf Hansson wrote: > On Fri, 28 Aug 2020 at 06:24, Christoph Hellwig wrote: > > > > On Thu, Aug 27, 2020 at 10:11:53PM -0400, Rich Felker wrote: > > > > This change broke SD card support on J2 because MMC_SPI spuriously > > > > depends on HAS_DMA. It

Re: [PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU

2020-08-28 Thread Ulf Hansson
On Fri, 28 Aug 2020 at 06:24, Christoph Hellwig wrote: > > On Thu, Aug 27, 2020 at 10:11:53PM -0400, Rich Felker wrote: > > > This change broke SD card support on J2 because MMC_SPI spuriously > > > depends on HAS_DMA. It looks like it can be fixed just by removing > > > that dependency from

Re: [PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU

2020-08-27 Thread Christoph Hellwig
On Thu, Aug 27, 2020 at 10:11:53PM -0400, Rich Felker wrote: > > This change broke SD card support on J2 because MMC_SPI spuriously > > depends on HAS_DMA. It looks like it can be fixed just by removing > > that dependency from drivers/mmc/host/Kconfig. > > It can't. mmp_spi_probe fails with

Re: [PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU

2020-08-27 Thread Rich Felker
On Thu, Aug 27, 2020 at 10:00:48PM -0400, Rich Felker wrote: > On Tue, Jul 14, 2020 at 02:18:55PM +0200, Christoph Hellwig wrote: > > The code handling non-coherent DMA depends on being able to remap code > > as non-cached. But that can't be done without an MMU, so using this > > option on NOMMU

Re: [PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU

2020-08-27 Thread Rich Felker
On Tue, Jul 14, 2020 at 02:18:55PM +0200, Christoph Hellwig wrote: > The code handling non-coherent DMA depends on being able to remap code > as non-cached. But that can't be done without an MMU, so using this > option on NOMMU builds is broken. > > Signed-off-by: Christoph Hellwig > --- >

[PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU

2020-07-14 Thread Christoph Hellwig
The code handling non-coherent DMA depends on being able to remap code as non-cached. But that can't be done without an MMU, so using this option on NOMMU builds is broken. Signed-off-by: Christoph Hellwig --- arch/sh/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU

2020-06-28 Thread Christoph Hellwig
On Sat, Jun 27, 2020 at 08:01:17PM -0500, Rob Landley wrote: > On 6/26/20 3:07 AM, Christoph Hellwig wrote: > > The code handling non-coherent DMA depends on being able to remap code > > as non-cached. But that can't be done without an MMU, so using this > > option on NOMMU builds is broken. > >

Re: [PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU

2020-06-27 Thread Rob Landley
On 6/26/20 3:07 AM, Christoph Hellwig wrote: > The code handling non-coherent DMA depends on being able to remap code > as non-cached. But that can't be done without an MMU, so using this > option on NOMMU builds is broken. I'm working on a nommu j-core board that's doing DMA behind the OS's

[PATCH 09/10] sh: don't allow non-coherent DMA for NOMMU

2020-06-26 Thread Christoph Hellwig
The code handling non-coherent DMA depends on being able to remap code as non-cached. But that can't be done without an MMU, so using this option on NOMMU builds is broken. Signed-off-by: Christoph Hellwig --- arch/sh/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git