Re: [PATCH 09/11] epoll: Remove unnecessary error path

2013-09-30 Thread Andi Kleen
> > @@ -1276,15 +1276,6 @@ static int ep_insert(struct eventpoll *ep, struct > > epoll_event *event, > > */ > > revents = ep_item_poll(epi, &epq.pt); > > ep_item_poll calls f_op->poll, which calls poll_wait(). > poll_wait() will call ep_ptable_queue_proc. Thanks. Good point. -Andi -- To

Re: [PATCH 09/11] epoll: Remove unnecessary error path

2013-09-30 Thread Eric Wong
Andi Kleen wrote: > From: Andi Kleen > > A static checker was pointing out that nothing can possible set > nwait < 0 in this path. The comment and the check appears to be > outdated. Remove it. I don't think so... > Cc: v...@zeniv.linux.org.uk > Signed-off-by: Andi Kleen > --- > fs/eventpoll

[PATCH 09/11] epoll: Remove unnecessary error path

2013-09-30 Thread Andi Kleen
From: Andi Kleen A static checker was pointing out that nothing can possible set nwait < 0 in this path. The comment and the check appears to be outdated. Remove it. Cc: v...@zeniv.linux.org.uk Signed-off-by: Andi Kleen --- fs/eventpoll.c | 10 -- 1 file changed, 10 deletions(-) diff