Re: [PATCH 09/11] misc: throttler: Add core support for non-thermal throttling

2018-05-30 Thread Chanwoo Choi
Hi, On 2018년 05월 30일 05:57, Matthias Kaehlcke wrote: > On Mon, May 28, 2018 at 04:32:37PM +0900, Chanwoo Choi wrote: > >> IMHO, you better to split out the devfreq patches from >> 'throttler' patch set. Because I'm not sure throttler is either >> necessary or not. >> >> After finishing the

Re: [PATCH 09/11] misc: throttler: Add core support for non-thermal throttling

2018-05-30 Thread Chanwoo Choi
Hi, On 2018년 05월 30일 05:57, Matthias Kaehlcke wrote: > On Mon, May 28, 2018 at 04:32:37PM +0900, Chanwoo Choi wrote: > >> IMHO, you better to split out the devfreq patches from >> 'throttler' patch set. Because I'm not sure throttler is either >> necessary or not. >> >> After finishing the

Re: [PATCH 09/11] misc: throttler: Add core support for non-thermal throttling

2018-05-29 Thread Matthias Kaehlcke
On Mon, May 28, 2018 at 10:08:26AM +0200, Greg Kroah-Hartman wrote: > On Fri, May 25, 2018 at 01:30:41PM -0700, Matthias Kaehlcke wrote: > > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > > index 20be70c3f118..01a1714dd2ad 100644 > > --- a/drivers/misc/Makefile > > +++

Re: [PATCH 09/11] misc: throttler: Add core support for non-thermal throttling

2018-05-29 Thread Matthias Kaehlcke
On Mon, May 28, 2018 at 10:08:26AM +0200, Greg Kroah-Hartman wrote: > On Fri, May 25, 2018 at 01:30:41PM -0700, Matthias Kaehlcke wrote: > > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > > index 20be70c3f118..01a1714dd2ad 100644 > > --- a/drivers/misc/Makefile > > +++

Re: [PATCH 09/11] misc: throttler: Add core support for non-thermal throttling

2018-05-29 Thread Matthias Kaehlcke
On Mon, May 28, 2018 at 04:32:37PM +0900, Chanwoo Choi wrote: > IMHO, you better to split out the devfreq patches from > 'throttler' patch set. Because I'm not sure throttler is either > necessary or not. > > After finishing the review of 'throttler' patches without devfreq handling, > it would

Re: [PATCH 09/11] misc: throttler: Add core support for non-thermal throttling

2018-05-29 Thread Matthias Kaehlcke
On Mon, May 28, 2018 at 04:32:37PM +0900, Chanwoo Choi wrote: > IMHO, you better to split out the devfreq patches from > 'throttler' patch set. Because I'm not sure throttler is either > necessary or not. > > After finishing the review of 'throttler' patches without devfreq handling, > it would

Re: [PATCH 09/11] misc: throttler: Add core support for non-thermal throttling

2018-05-28 Thread Greg Kroah-Hartman
On Fri, May 25, 2018 at 01:30:41PM -0700, Matthias Kaehlcke wrote: > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > index 20be70c3f118..01a1714dd2ad 100644 > --- a/drivers/misc/Makefile > +++ b/drivers/misc/Makefile > @@ -57,3 +57,4 @@ obj-$(CONFIG_ASPEED_LPC_SNOOP) +=

Re: [PATCH 09/11] misc: throttler: Add core support for non-thermal throttling

2018-05-28 Thread Greg Kroah-Hartman
On Fri, May 25, 2018 at 01:30:41PM -0700, Matthias Kaehlcke wrote: > diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile > index 20be70c3f118..01a1714dd2ad 100644 > --- a/drivers/misc/Makefile > +++ b/drivers/misc/Makefile > @@ -57,3 +57,4 @@ obj-$(CONFIG_ASPEED_LPC_SNOOP) +=

Re: [PATCH 09/11] misc: throttler: Add core support for non-thermal throttling

2018-05-28 Thread Chanwoo Choi
Hi Matthias, IMHO, you better to split out the devfreq patches from 'throttler' patch set. Because I'm not sure throttler is either necessary or not. After finishing the review of 'throttler' patches without devfreq handling, it would be better for you to send devfreq patches separately.

Re: [PATCH 09/11] misc: throttler: Add core support for non-thermal throttling

2018-05-28 Thread Chanwoo Choi
Hi Matthias, IMHO, you better to split out the devfreq patches from 'throttler' patch set. Because I'm not sure throttler is either necessary or not. After finishing the review of 'throttler' patches without devfreq handling, it would be better for you to send devfreq patches separately.

[PATCH 09/11] misc: throttler: Add core support for non-thermal throttling

2018-05-25 Thread Matthias Kaehlcke
The purpose of the throttler is to provide support for non-thermal throttling. Throttling is triggered by external event, e.g. the detection of a high battery discharge current, close to the OCP limit of the battery. The throttler is only in charge of the throttling, not the monitoring, which is

[PATCH 09/11] misc: throttler: Add core support for non-thermal throttling

2018-05-25 Thread Matthias Kaehlcke
The purpose of the throttler is to provide support for non-thermal throttling. Throttling is triggered by external event, e.g. the detection of a high battery discharge current, close to the OCP limit of the battery. The throttler is only in charge of the throttling, not the monitoring, which is