Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts

2013-11-12 Thread Michael Schmitz
Thomas, I suppose setting the flag can be done in the corresponding irq startup function, instead of when setting up the irq controller? irq_startup() is called with irq_desc->lock held and irq_set_status_flags() wants desc->lock as well. Deadlock Thanks, point taken. And no, you don't

Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts

2013-11-12 Thread Thomas Gleixner
On Sun, 10 Nov 2013, Michael Schmitz wrote: > Your patch works just fine, thanks. > > I suppose setting the flag can be done in the corresponding irq startup > function, instead of when setting up the irq controller? irq_startup() is called with irq_desc->lock held and irq_set_status_flags()

Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts

2013-11-12 Thread Thomas Gleixner
On Sun, 10 Nov 2013, Michael Schmitz wrote: Your patch works just fine, thanks. I suppose setting the flag can be done in the corresponding irq startup function, instead of when setting up the irq controller? irq_startup() is called with irq_desc-lock held and irq_set_status_flags() wants

Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts

2013-11-12 Thread Michael Schmitz
Thomas, I suppose setting the flag can be done in the corresponding irq startup function, instead of when setting up the irq controller? irq_startup() is called with irq_desc-lock held and irq_set_status_flags() wants desc-lock as well. Deadlock Thanks, point taken. And no, you don't

Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts

2013-11-10 Thread Michael Schmitz
Thomas, Does the following patch solve the problem? You need to call irq_set_status_flags(irq, IRQ_IS_POLLED); when setting up the interrupt controller for those polled interrupt lines. Your patch works just fine, thanks. I suppose setting the flag can be done in the corresponding irq

Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts

2013-11-10 Thread Michael Schmitz
Thomas, Does the following patch solve the problem? You need to call irq_set_status_flags(irq, IRQ_IS_POLLED); when setting up the interrupt controller for those polled interrupt lines. Your patch works just fine, thanks. I suppose setting the flag can be done in the corresponding irq

Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts

2013-11-07 Thread Michael Schmitz
Thomas, This is a temporary hack to allow timer based polling of the Atari ROM port network and USB cards only. Suggestions on how to properly handle this in the normal interrupt framework are most welcome. So you're polling devices which have no hardware interrupt from the timer interrupt.

Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts

2013-11-07 Thread Michael Schmitz
Thomas, This is a temporary hack to allow timer based polling of the Atari ROM port network and USB cards only. Suggestions on how to properly handle this in the normal interrupt framework are most welcome. So you're polling devices which have no hardware interrupt from the timer interrupt.

Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts

2013-11-06 Thread Thomas Gleixner
On Wed, 20 Mar 2013, Geert Uytterhoeven wrote: > On Sun, Feb 10, 2013 at 11:36 AM, Geert Uytterhoeven > wrote: > > On Thu, Jan 31, 2013 at 1:23 AM, Michael Schmitz > > wrote: > >> [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer

Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts

2013-11-06 Thread Thomas Gleixner
On Wed, 20 Mar 2013, Geert Uytterhoeven wrote: On Sun, Feb 10, 2013 at 11:36 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Thu, Jan 31, 2013 at 1:23 AM, Michael Schmitz schmitz...@gmail.com wrote: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft

Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts

2013-03-20 Thread Geert Uytterhoeven
On Sun, Feb 10, 2013 at 11:36 AM, Geert Uytterhoeven wrote: > On Thu, Jan 31, 2013 at 1:23 AM, Michael Schmitz wrote: >> [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft >> interrupts - >> experimental hack to avoid unhandled in

Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts

2013-03-20 Thread Geert Uytterhoeven
On Sun, Feb 10, 2013 at 11:36 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Thu, Jan 31, 2013 at 1:23 AM, Michael Schmitz schmitz...@gmail.com wrote: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts - experimental hack to avoid unhandled

Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts

2013-02-10 Thread Geert Uytterhoeven
On Thu, Jan 31, 2013 at 1:23 AM, Michael Schmitz wrote: > [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft > interrupts - > experimental hack to avoid unhandled interrupt timer to fire > on EtherNEC/NetUSBee cards that have no hardwa

Re: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts

2013-02-10 Thread Geert Uytterhoeven
On Thu, Jan 31, 2013 at 1:23 AM, Michael Schmitz schmitz...@gmail.com wrote: [PATCH 09/17] [m68k] IRQ: add handle_polled_irq() for timer based soft interrupts - experimental hack to avoid unhandled interrupt timer to fire on EtherNEC/NetUSBee cards that have no hardware