Re: [PATCH 09/22] gpiolib: cdev: rename priv to gcdev

2020-06-25 Thread Bartosz Golaszewski
On Thu, Jun 25, 2020 at 1:16 AM Kent Gibson wrote: > > On Wed, Jun 24, 2020 at 04:20:49PM +0200, Bartosz Golaszewski wrote: > > śr., 24 cze 2020 o 16:19 Kent Gibson napisał(a): > > > > > > On Wed, Jun 24, 2020 at 04:04:09PM +0200, Bartosz Golaszewski wrote: > > > > wt., 23 cze 2020 o 06:02 Kent

Re: [PATCH 09/22] gpiolib: cdev: rename priv to gcdev

2020-06-24 Thread Kent Gibson
On Wed, Jun 24, 2020 at 04:20:49PM +0200, Bartosz Golaszewski wrote: > śr., 24 cze 2020 o 16:19 Kent Gibson napisał(a): > > > > On Wed, Jun 24, 2020 at 04:04:09PM +0200, Bartosz Golaszewski wrote: > > > wt., 23 cze 2020 o 06:02 Kent Gibson napisał(a): > > > > > > > > Rename priv to gcdev to

Re: [PATCH 09/22] gpiolib: cdev: rename priv to gcdev

2020-06-24 Thread Bartosz Golaszewski
śr., 24 cze 2020 o 16:19 Kent Gibson napisał(a): > > On Wed, Jun 24, 2020 at 04:04:09PM +0200, Bartosz Golaszewski wrote: > > wt., 23 cze 2020 o 06:02 Kent Gibson napisał(a): > > > > > > Rename priv to gcdev to improve readability. > > > > > > The name "priv" indicates that the object is pointed

Re: [PATCH 09/22] gpiolib: cdev: rename priv to gcdev

2020-06-24 Thread Kent Gibson
On Wed, Jun 24, 2020 at 04:04:09PM +0200, Bartosz Golaszewski wrote: > wt., 23 cze 2020 o 06:02 Kent Gibson napisał(a): > > > > Rename priv to gcdev to improve readability. > > > > The name "priv" indicates that the object is pointed to by > > file->private_data, not what the object is actually

Re: [PATCH 09/22] gpiolib: cdev: rename priv to gcdev

2020-06-24 Thread Bartosz Golaszewski
wt., 23 cze 2020 o 06:02 Kent Gibson napisał(a): > > Rename priv to gcdev to improve readability. > > The name "priv" indicates that the object is pointed to by > file->private_data, not what the object is actually is. > It is always used to point to a struct gpio_chardev_data so renaming > it to

[PATCH 09/22] gpiolib: cdev: rename priv to gcdev

2020-06-22 Thread Kent Gibson
Rename priv to gcdev to improve readability. The name "priv" indicates that the object is pointed to by file->private_data, not what the object is actually is. It is always used to point to a struct gpio_chardev_data so renaming it to gcdev seemed as good as anything, and certainly clearer than