Re: [PATCH 09/44 take 2] [UBI] debug unit header

2007-02-19 Thread Artem Bityutskiy
On Mon, 2007-02-19 at 08:02 -0600, Josh Boyer wrote: > It is not the comment that annoys people. Arnd was saying that the > entire debug unit should not exist. There is many per-subsystem debugging stuff in kernel. I do not see _objective_ any reason to prohibit use have our own debugging stuff

Re: [PATCH 09/44 take 2] [UBI] debug unit header

2007-02-19 Thread Josh Boyer
On Mon, 2007-02-19 at 14:33 +0200, Artem Bityutskiy wrote: > On Sat, 2007-02-17 at 22:18 +0100, Arnd Bergmann wrote: > > If you feel that Linux needs rich debugging capabilities, then submit > > a patch for that independent of UBI. > > I will fix the comment which annoys. It is not the comment

Re: [PATCH 09/44 take 2] [UBI] debug unit header

2007-02-19 Thread Artem Bityutskiy
On Sat, 2007-02-17 at 22:18 +0100, Arnd Bergmann wrote: > If you feel that Linux needs rich debugging capabilities, then submit > a patch for that independent of UBI. I will fix the comment which annoys. -- Best regards, Artem Bityutskiy (Битюцкий Артём) - To unsubscribe from this list: send

Re: [PATCH 09/44 take 2] [UBI] debug unit header

2007-02-19 Thread Christoph Hellwig
On Sat, Feb 17, 2007 at 10:18:21PM +0100, Arnd Bergmann wrote: > On Saturday 17 February 2007 17:55, Artem Bityutskiy wrote: > > + > > +/** > > + * UBI debugging unit. > > + * > > + * UBI provides rich debugging capabilities which are implemented in > > + * this unit. > > Stop right here. You

Re: [PATCH 09/44 take 2] [UBI] debug unit header

2007-02-19 Thread Christoph Hellwig
On Sat, Feb 17, 2007 at 10:18:21PM +0100, Arnd Bergmann wrote: On Saturday 17 February 2007 17:55, Artem Bityutskiy wrote: + +/** + * UBI debugging unit. + * + * UBI provides rich debugging capabilities which are implemented in + * this unit. Stop right here. You should be doing

Re: [PATCH 09/44 take 2] [UBI] debug unit header

2007-02-19 Thread Artem Bityutskiy
On Sat, 2007-02-17 at 22:18 +0100, Arnd Bergmann wrote: If you feel that Linux needs rich debugging capabilities, then submit a patch for that independent of UBI. I will fix the comment which annoys. -- Best regards, Artem Bityutskiy (Битюцкий Артём) - To unsubscribe from this list: send the

Re: [PATCH 09/44 take 2] [UBI] debug unit header

2007-02-19 Thread Josh Boyer
On Mon, 2007-02-19 at 14:33 +0200, Artem Bityutskiy wrote: On Sat, 2007-02-17 at 22:18 +0100, Arnd Bergmann wrote: If you feel that Linux needs rich debugging capabilities, then submit a patch for that independent of UBI. I will fix the comment which annoys. It is not the comment that

Re: [PATCH 09/44 take 2] [UBI] debug unit header

2007-02-19 Thread Artem Bityutskiy
On Mon, 2007-02-19 at 08:02 -0600, Josh Boyer wrote: It is not the comment that annoys people. Arnd was saying that the entire debug unit should not exist. There is many per-subsystem debugging stuff in kernel. I do not see _objective_ any reason to prohibit use have our own debugging stuff in

Re: [PATCH 09/44 take 2] [UBI] debug unit header

2007-02-17 Thread Arnd Bergmann
On Saturday 17 February 2007 17:55, Artem Bityutskiy wrote: > + > +/** > + * UBI debugging unit. > + * > + * UBI provides rich debugging capabilities which are implemented in > + * this unit. Stop right here. You should be doing one thing and do it right. Since the point of your patches is to do

[PATCH 09/44 take 2] [UBI] debug unit header

2007-02-17 Thread Artem Bityutskiy
diff -auNrp tmp-from/drivers/mtd/ubi/debug.h tmp-to/drivers/mtd/ubi/debug.h --- tmp-from/drivers/mtd/ubi/debug.h1970-01-01 02:00:00.0 +0200 +++ tmp-to/drivers/mtd/ubi/debug.h 2007-02-17 18:07:26.0 +0200 @@ -0,0 +1,284 @@ +/* + * Copyright (c) International Business

[PATCH 09/44 take 2] [UBI] debug unit header

2007-02-17 Thread Artem Bityutskiy
diff -auNrp tmp-from/drivers/mtd/ubi/debug.h tmp-to/drivers/mtd/ubi/debug.h --- tmp-from/drivers/mtd/ubi/debug.h1970-01-01 02:00:00.0 +0200 +++ tmp-to/drivers/mtd/ubi/debug.h 2007-02-17 18:07:26.0 +0200 @@ -0,0 +1,284 @@ +/* + * Copyright (c) International Business

Re: [PATCH 09/44 take 2] [UBI] debug unit header

2007-02-17 Thread Arnd Bergmann
On Saturday 17 February 2007 17:55, Artem Bityutskiy wrote: + +/** + * UBI debugging unit. + * + * UBI provides rich debugging capabilities which are implemented in + * this unit. Stop right here. You should be doing one thing and do it right. Since the point of your patches is to do volume