Re: [PATCH 1/1] Fixed to codestyle

On 12/12/16 2:50 PM, Joe Perches wrote: > On Mon, 2016-12-12 at 14:41 -0600, Eric Sandeen wrote: >> On 12/12/16 2:34 PM, Ozgur Karatas wrote: > [] >>> Can you tell me the true code style? should use to (* uuid)? >>> I'm learn to new and I'm newbies :) >> >> Well, rule #1 for newbies is "code

Re: [PATCH 1/1] Fixed to codestyle

On 12/12/16 2:50 PM, Joe Perches wrote: > On Mon, 2016-12-12 at 14:41 -0600, Eric Sandeen wrote: >> On 12/12/16 2:34 PM, Ozgur Karatas wrote: > [] >>> Can you tell me the true code style? should use to (* uuid)? >>> I'm learn to new and I'm newbies :) >> >> Well, rule #1 for newbies is "code

Re: [PATCH 1/1] Fixed to codestyle

12.12.2016, 22:50, "Joe Perches" : > On Mon, 2016-12-12 at 14:41 -0600, Eric Sandeen wrote: >>  On 12/12/16 2:34 PM, Ozgur Karatas wrote: > > [] >>  > Can you tell me the true code style? should use to (* uuid)? >>  > I'm learn to new and I'm newbies :) >> >>  Well, rule #1 for

Re: [PATCH 1/1] Fixed to codestyle

12.12.2016, 22:50, "Joe Perches" : > On Mon, 2016-12-12 at 14:41 -0600, Eric Sandeen wrote: >>  On 12/12/16 2:34 PM, Ozgur Karatas wrote: > > [] >>  > Can you tell me the true code style? should use to (* uuid)? >>  > I'm learn to new and I'm newbies :) >> >>  Well, rule #1 for newbies is "code

Re: [PATCH 1/1] Fixed to codestyle

On Mon, 2016-12-12 at 14:41 -0600, Eric Sandeen wrote: > On 12/12/16 2:34 PM, Ozgur Karatas wrote: [] > > Can you tell me the true code style? should use to (* uuid)? > > I'm learn to new and I'm newbies :) > > Well, rule #1 for newbies is "code style patches aren't > very useful, and usually

Re: [PATCH 1/1] Fixed to codestyle

On Mon, 2016-12-12 at 14:41 -0600, Eric Sandeen wrote: > On 12/12/16 2:34 PM, Ozgur Karatas wrote: [] > > Can you tell me the true code style? should use to (* uuid)? > > I'm learn to new and I'm newbies :) > > Well, rule #1 for newbies is "code style patches aren't > very useful, and usually

Re: [PATCH 1/1] Fixed to codestyle

12.12.2016, 22:41, "Eric Sandeen" : > Well, rule #1 for newbies is "code style patches aren't > very useful, and usually are not welcomed by the project." > > Making style changes just because checkpatch told you to is > not particularly helpful. If it were important, it would

Re: [PATCH 1/1] Fixed to codestyle

12.12.2016, 22:41, "Eric Sandeen" : > Well, rule #1 for newbies is "code style patches aren't > very useful, and usually are not welcomed by the project." > > Making style changes just because checkpatch told you to is > not particularly helpful. If it were important, it would have > been done by

Re: [PATCH 1/1] Fixed to codestyle

On 12/12/16 2:34 PM, Ozgur Karatas wrote: > 12.12.2016, 20:35, "Eric Sandeen" : >> On 12/12/16 12:14 PM, Joe Perches wrote: ... > { > xfs_uu_t *uup = (xfs_uu_t *)uuid; > > @@ -51,8 +51,8 @@ uuid_is_nil(uuid_t *uuid) > if (uuid ==

Re: [PATCH 1/1] Fixed to codestyle

On 12/12/16 2:34 PM, Ozgur Karatas wrote: > 12.12.2016, 20:35, "Eric Sandeen" : >> On 12/12/16 12:14 PM, Joe Perches wrote: ... > { > xfs_uu_t *uup = (xfs_uu_t *)uuid; > > @@ -51,8 +51,8 @@ uuid_is_nil(uuid_t *uuid) > if (uuid == NULL) >

Re: [PATCH 1/1] Fixed to codestyle

12.12.2016, 20:14, "Joe Perches" : > On Mon, 2016-12-12 at 07:49 -0600, Eric Sandeen wrote: >>  On 12/12/16 4:53 AM, Ozgur Karatas wrote: >>  > >>  > Hello, >>  > >>  > I have error to use uuid and I think the functions should be used when >> -i'm eye-catching- "(* uuid)". >>  >

Re: [PATCH 1/1] Fixed to codestyle

12.12.2016, 20:14, "Joe Perches" : > On Mon, 2016-12-12 at 07:49 -0600, Eric Sandeen wrote: >>  On 12/12/16 4:53 AM, Ozgur Karatas wrote: >>  > >>  > Hello, >>  > >>  > I have error to use uuid and I think the functions should be used when >> -i'm eye-catching- "(* uuid)". >>  > I tested it. >>  

Re: [PATCH 1/1] Fixed to codestyle

12.12.2016, 20:35, "Eric Sandeen" : > On 12/12/16 12:14 PM, Joe Perches wrote: >>  On Mon, 2016-12-12 at 07:49 -0600, Eric Sandeen wrote: >>>  On 12/12/16 4:53 AM, Ozgur Karatas wrote:  Hello,  I have error to use uuid and I think the functions should be used

Re: [PATCH 1/1] Fixed to codestyle

12.12.2016, 20:35, "Eric Sandeen" : > On 12/12/16 12:14 PM, Joe Perches wrote: >>  On Mon, 2016-12-12 at 07:49 -0600, Eric Sandeen wrote: >>>  On 12/12/16 4:53 AM, Ozgur Karatas wrote:  Hello,  I have error to use uuid and I think the functions should be used when -i'm

Re: [PATCH 1/1] Fixed to codestyle

On 12/12/16 12:14 PM, Joe Perches wrote: > On Mon, 2016-12-12 at 07:49 -0600, Eric Sandeen wrote: >> On 12/12/16 4:53 AM, Ozgur Karatas wrote: >>> >>> Hello, >>> >>> I have error to use uuid and I think the functions should be used when -i'm >>> eye-catching- "(* uuid)". >>> I tested it. >>>

Re: [PATCH 1/1] Fixed to codestyle

On 12/12/16 12:14 PM, Joe Perches wrote: > On Mon, 2016-12-12 at 07:49 -0600, Eric Sandeen wrote: >> On 12/12/16 4:53 AM, Ozgur Karatas wrote: >>> >>> Hello, >>> >>> I have error to use uuid and I think the functions should be used when -i'm >>> eye-catching- "(* uuid)". >>> I tested it. >>>

Re: [PATCH 1/1] Fixed to codestyle

On Mon, 2016-12-12 at 07:49 -0600, Eric Sandeen wrote: > On 12/12/16 4:53 AM, Ozgur Karatas wrote: > > > > Hello, > > > > I have error to use uuid and I think the functions should be used when -i'm > > eye-catching- "(* uuid)". > > I tested it. > > > > Regards, > > > > Signed-off-by: Ozgur

Re: [PATCH 1/1] Fixed to codestyle

On Mon, 2016-12-12 at 07:49 -0600, Eric Sandeen wrote: > On 12/12/16 4:53 AM, Ozgur Karatas wrote: > > > > Hello, > > > > I have error to use uuid and I think the functions should be used when -i'm > > eye-catching- "(* uuid)". > > I tested it. > > > > Regards, > > > > Signed-off-by: Ozgur

Re: [PATCH 1/1] Fixed to codestyle

On 12/12/16 4:53 AM, Ozgur Karatas wrote: > > Hello, > > I have error to use uuid and I think the functions should be used when -i'm > eye-catching- "(* uuid)". > I tested it. > > Regards, > > Signed-off-by: Ozgur Karatas NAK This doesn't fix code style at all;

Re: [PATCH 1/1] Fixed to codestyle

On 12/12/16 4:53 AM, Ozgur Karatas wrote: > > Hello, > > I have error to use uuid and I think the functions should be used when -i'm > eye-catching- "(* uuid)". > I tested it. > > Regards, > > Signed-off-by: Ozgur Karatas NAK This doesn't fix code style at all; there is no need and no

[PATCH 1/1] Fixed to codestyle

Hello, I have error to use uuid and I think the functions should be used when -i'm eye-catching- "(* uuid)". I tested it. Regards, Signed-off-by: Ozgur Karatas --- diff --git a/fs/xfs/uuid.c b/fs/xfs/uuid.c index b83f76b..cd8bc8e 100644 --- a/fs/xfs/uuid.c +++

[PATCH 1/1] Fixed to codestyle

Hello, I have error to use uuid and I think the functions should be used when -i'm eye-catching- "(* uuid)". I tested it. Regards, Signed-off-by: Ozgur Karatas --- diff --git a/fs/xfs/uuid.c b/fs/xfs/uuid.c index b83f76b..cd8bc8e 100644 --- a/fs/xfs/uuid.c +++ b/fs/xfs/uuid.c @@ -33,7 +33,7