Re: [PATCH 1/1] Staging: android: ion: Fixed coding style issues

2016-10-02 Thread Greg KH
On Wed, Sep 28, 2016 at 10:21:16PM +0530, shyam saini wrote: > Fixed switch case indentation issue and void function return statement > issue That's two different things in one patch, please break this up into two different patches (which will let me reject one of them, see the archives for

Re: [PATCH 1/1] Staging: android: ion: Fixed coding style issues

2016-10-02 Thread Greg KH
On Wed, Sep 28, 2016 at 10:21:16PM +0530, shyam saini wrote: > Fixed switch case indentation issue and void function return statement > issue That's two different things in one patch, please break this up into two different patches (which will let me reject one of them, see the archives for

[PATCH 1/1] Staging: android: ion: Fixed coding style issues

2016-09-28 Thread shyam saini
Fixed switch case indentation issue and void function return statement issue Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[PATCH 1/1] Staging: android: ion: Fixed coding style issues

2016-09-28 Thread shyam saini
Fixed switch case indentation issue and void function return statement issue Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c

Re: [PATCH 1/1] Staging: android: ion: Fixed coding style issues

2016-09-28 Thread Greg KH
On Wed, Sep 28, 2016 at 08:51:43PM +0530, shyam saini wrote: > Fixed checkpatch coding style issues What specific issues? Always be descriptive, look at previous patches in the staging tree for examples. thanks, greg k-h

Re: [PATCH 1/1] Staging: android: ion: Fixed coding style issues

2016-09-28 Thread Greg KH
On Wed, Sep 28, 2016 at 08:51:43PM +0530, shyam saini wrote: > Fixed checkpatch coding style issues What specific issues? Always be descriptive, look at previous patches in the staging tree for examples. thanks, greg k-h

[PATCH 1/1] Staging: android: ion: Fixed coding style issues

2016-09-28 Thread shyam saini
Fixed checkpatch coding style issues Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c

[PATCH 1/1] Staging: android: ion: Fixed coding style issues

2016-09-28 Thread shyam saini
Fixed checkpatch coding style issues Signed-off-by: shyam saini --- drivers/staging/android/ion/ion_of.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c index de0899a..01f3067