Re: [PATCH 1/1] blk-mq: fill header with kernel-doc

2019-09-30 Thread André Almeida
On 9/30/19 6:54 PM, Minwoo Im wrote: > Hi André, > >> -/* >> +/** >> + * blk_mq_rq_from_pdu - cast a PDU to a request >> + * @pdu: the PDU (protocol unit request) to be casted > > It makes sense, but it looks like PDU stands for protocol unit request. > Could we have it "PDU(Protocol Data Unit)"

Re: [PATCH 1/1] blk-mq: fill header with kernel-doc

2019-09-30 Thread André Almeida
On 9/30/19 7:01 PM, Bart Van Assche wrote: > On 9/30/19 12:48 PM, André Almeida wrote: >> Insert documentation for structs, enums and functions at header file. >> Format existing and new comments at struct blk_mq_ops as >> kernel-doc comments. > > Hi André, > > Seeing the documentation being impr