Re: [PATCH 1/1] block: CFQ refcounting fix

2005-08-31 Thread Jens Axboe
On Wed, Aug 31 2005, Brian King wrote: > diff -puN drivers/block/cfq-iosched.c~cfq_refcnt_fix > drivers/block/cfq-iosched.c > --- linux-2.6/drivers/block/cfq-iosched.c~cfq_refcnt_fix 2005-08-30 > 17:26:55.0 -0500 > +++ linux-2.6-bjking1/drivers/block/cfq-iosched.c 2005-08-31 >

Re: [PATCH 1/1] block: CFQ refcounting fix

2005-08-31 Thread Brian King
Jens Axboe wrote: > On Wed, Aug 31 2005, Brian King wrote: > >>Jens Axboe wrote: >> >>>On Tue, Aug 30 2005, [EMAIL PROTECTED] wrote: >>> >>> I ran across a memory leak related to the cfq scheduler. The cfq init function increments the refcnt of the associated request_queue. This

Re: [PATCH 1/1] block: CFQ refcounting fix

2005-08-31 Thread Jens Axboe
On Wed, Aug 31 2005, Brian King wrote: > Jens Axboe wrote: > > On Tue, Aug 30 2005, [EMAIL PROTECTED] wrote: > > > >>I ran across a memory leak related to the cfq scheduler. The cfq > >>init function increments the refcnt of the associated request_queue. > >>This refcount gets decremented in

Re: [PATCH 1/1] block: CFQ refcounting fix

2005-08-31 Thread Brian King
Jens Axboe wrote: > On Tue, Aug 30 2005, [EMAIL PROTECTED] wrote: > >>I ran across a memory leak related to the cfq scheduler. The cfq >>init function increments the refcnt of the associated request_queue. >>This refcount gets decremented in cfq's exit function. Since blk_cleanup_queue >>only

Re: [PATCH 1/1] block: CFQ refcounting fix

2005-08-31 Thread Jens Axboe
On Tue, Aug 30 2005, [EMAIL PROTECTED] wrote: > > I ran across a memory leak related to the cfq scheduler. The cfq > init function increments the refcnt of the associated request_queue. > This refcount gets decremented in cfq's exit function. Since blk_cleanup_queue > only calls the elevator exit

Re: [PATCH 1/1] block: CFQ refcounting fix

2005-08-31 Thread Jens Axboe
On Tue, Aug 30 2005, [EMAIL PROTECTED] wrote: I ran across a memory leak related to the cfq scheduler. The cfq init function increments the refcnt of the associated request_queue. This refcount gets decremented in cfq's exit function. Since blk_cleanup_queue only calls the elevator exit

Re: [PATCH 1/1] block: CFQ refcounting fix

2005-08-31 Thread Brian King
Jens Axboe wrote: On Tue, Aug 30 2005, [EMAIL PROTECTED] wrote: I ran across a memory leak related to the cfq scheduler. The cfq init function increments the refcnt of the associated request_queue. This refcount gets decremented in cfq's exit function. Since blk_cleanup_queue only calls the

Re: [PATCH 1/1] block: CFQ refcounting fix

2005-08-31 Thread Jens Axboe
On Wed, Aug 31 2005, Brian King wrote: Jens Axboe wrote: On Tue, Aug 30 2005, [EMAIL PROTECTED] wrote: I ran across a memory leak related to the cfq scheduler. The cfq init function increments the refcnt of the associated request_queue. This refcount gets decremented in cfq's exit

Re: [PATCH 1/1] block: CFQ refcounting fix

2005-08-31 Thread Brian King
Jens Axboe wrote: On Wed, Aug 31 2005, Brian King wrote: Jens Axboe wrote: On Tue, Aug 30 2005, [EMAIL PROTECTED] wrote: I ran across a memory leak related to the cfq scheduler. The cfq init function increments the refcnt of the associated request_queue. This refcount gets decremented in

Re: [PATCH 1/1] block: CFQ refcounting fix

2005-08-31 Thread Jens Axboe
On Wed, Aug 31 2005, Brian King wrote: diff -puN drivers/block/cfq-iosched.c~cfq_refcnt_fix drivers/block/cfq-iosched.c --- linux-2.6/drivers/block/cfq-iosched.c~cfq_refcnt_fix 2005-08-30 17:26:55.0 -0500 +++ linux-2.6-bjking1/drivers/block/cfq-iosched.c 2005-08-31

[PATCH 1/1] block: CFQ refcounting fix

2005-08-30 Thread brking
I ran across a memory leak related to the cfq scheduler. The cfq init function increments the refcnt of the associated request_queue. This refcount gets decremented in cfq's exit function. Since blk_cleanup_queue only calls the elevator exit function when its refcnt goes to zero, the request_q

[PATCH 1/1] block: CFQ refcounting fix

2005-08-30 Thread brking
I ran across a memory leak related to the cfq scheduler. The cfq init function increments the refcnt of the associated request_queue. This refcount gets decremented in cfq's exit function. Since blk_cleanup_queue only calls the elevator exit function when its refcnt goes to zero, the request_q