Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-05-05 Thread Li, Zhen-Hua (USL-China)
On 04/29/2013 02:55 AM, Alan Stern wrote: On Sun, 28 Apr 2013, ZhenHua wrote: In fact, the patch is so easy that I am including it below. Please test this (without either of your patches) to see if it works. Alan Stern Index: usb-3.9/drivers/usb/host/uhci-hub.c ===

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-28 Thread Alan Stern
On Sun, 28 Apr 2013, ZhenHua wrote: > >>> In fact, the patch is so easy that I am including it below. Please > >>> test this (without either of your patches) to see if it works. > >>> > >>> Alan Stern > >>> > >>> > >>> > >>> > >>> Index: usb-3.9/drivers/usb/host/uhci-hub.c > >>> =

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-27 Thread ZhenHua
On 04/27/2013 11:14 PM, Alan Stern wrote: On Sat, 27 Apr 2013, ZhenHua wrote: On 04/27/2013 12:51 AM, Alan Stern wrote: On Fri, 26 Apr 2013, ZhenHua wrote: There is a function wait_for_HP() in uhci-hub.c. In this patch, it is used in suspend_rh(), I think this can be a solution. And I have

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-27 Thread Alan Stern
On Sat, 27 Apr 2013, ZhenHua wrote: > On 04/27/2013 12:51 AM, Alan Stern wrote: > > On Fri, 26 Apr 2013, ZhenHua wrote: > > > >> There is a function wait_for_HP() in uhci-hub.c. In this > >> patch, it is used in suspend_rh(), I think this can be a > >> solution. And I have tested this patch, it

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-26 Thread ZhenHua
On 04/27/2013 12:51 AM, Alan Stern wrote: On Fri, 26 Apr 2013, ZhenHua wrote: There is a function wait_for_HP() in uhci-hub.c. In this patch, it is used in suspend_rh(), I think this can be a solution. And I have tested this patch, it can fix the bug. I think there is another patch needed. A

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-26 Thread Alan Stern
On Fri, 26 Apr 2013, ZhenHua wrote: > There is a function wait_for_HP() in uhci-hub.c. In this > patch, it is used in suspend_rh(), I think this can be a > solution. And I have tested this patch, it can fix the bug. > > I think there is another patch needed. As Alan said in another > mail, in t

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-26 Thread ZhenHua
On 04/26/2013 03:50 PM, ZhenHua wrote: I think there is another patch needed. As Alan said in another mail, in the UHCI_RH_RUNNING_NODEVS case, it should not be stopped if the uhci device is HP iLo virtual usb. correct: it should not be auto stopped if the uhci device is HP iLo virtual usb.

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-26 Thread ZhenHua
There is a function wait_for_HP() in uhci-hub.c. In this patch, it is used in suspend_rh(), I think this can be a solution. And I have tested this patch, it can fix the bug. I think there is another patch needed. As Alan said in another mail, in the UHCI_RH_RUNNING_NODEVS case, it should not be

[PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-26 Thread Li, Zhen-Hua
This patch is trying to fix this bug on SLES11 SP2: https://bugzilla.novell.com/show_bug.cgi?id=817035 On a large HP system with 64T memory and 60 logical cpus, when usb driver inits the iLo Virtual USB Controller, there comes a warning "Controller not stopped yet!". It is because the HP iLo v

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-25 Thread ZhenHua
On 04/25/2013 10:54 PM, Alan Stern wrote: On Thu, 25 Apr 2013, ZhenHua wrote: +#define UHCI_SUSPENDRH_RETRY_MAX 10 +#define UHCI_SUSPENDRH_RETRY_DELAY100 Why is the delay set to 100 us? Isn't that excessively large? How long does it take for this controller to go into suspend? Thi

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-25 Thread Alan Stern
On Thu, 25 Apr 2013, Alan Stern wrote: > On Thu, 25 Apr 2013, ZhenHua wrote: > > > I send out this patch for the second time. > > Changed try to int. And modified the comment. > > You did not answer my question: How long does it take for the iLo > controller to go into suspend? Oops, sorry, I

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-25 Thread Alan Stern
On Thu, 25 Apr 2013, ZhenHua wrote: > >>> +#define UHCI_SUSPENDRH_RETRY_MAX 10 > >>> +#define UHCI_SUSPENDRH_RETRY_DELAY100 > > Why is the delay set to 100 us? Isn't that excessively large? How > > long does it take for this controller to go into suspend? > This controller will take abo

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-25 Thread Alan Stern
On Thu, 25 Apr 2013, ZhenHua wrote: > I send out this patch for the second time. > Changed try to int. And modified the comment. You did not answer my question: How long does it take for the iLo controller to go into suspend? Alan Stern -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-25 Thread ZhenHua
I send out this patch for the second time. Changed try to int. And modified the comment. On 04/25/2013 03:11 PM, Li, Zhen-Hua wrote: This patch is trying to fix this bug on SLES11 SP2: https://bugzilla.novell.com/show_bug.cgi?id=817035 On a large HP system with 64T memory and 60 logical cp

[PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-25 Thread Li, Zhen-Hua
This patch is trying to fix this bug on SLES11 SP2: https://bugzilla.novell.com/show_bug.cgi?id=817035 On a large HP system with 64T memory and 60 logical cpus, when usb driver inits the iLo Virtual USB Controller, there comes a warning "Controller not stopped yet!". It is because driver does

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-24 Thread ZhenHua
On 04/23/2013 11:10 PM, Alan Stern wrote: On Tue, 23 Apr 2013, Greg KH wrote: On Tue, Apr 23, 2013 at 03:15:01PM +0800, Li, Zhen-Hua wrote: From: "Li, Zhen-Hua" This patch is trying to fix bug QXCR1001261767. What is that bug number? Where can it be referenced? If you are going to put it

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-23 Thread ZhenHua
I did not found any url you can visit. And we will file a bug on SLES bugzilla site if possible. I paste the bug discription here: When booting SLES 11 SP2 on our server , messages like the following are logged during boot: [ 254.087187] uhci_hcd :07:00.4: Controller not stopped yet! T

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-23 Thread Greg KH
On Wed, Apr 24, 2013 at 07:55:18AM +0800, ZhenHua wrote: > On 04/23/2013 10:07 PM, Greg KH wrote: > >On Tue, Apr 23, 2013 at 03:15:01PM +0800, Li, Zhen-Hua wrote: > >>From: "Li, Zhen-Hua" > >> > >>This patch is trying to fix bug QXCR1001261767. > Sorry for the bug number. Please ignore this line.

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-23 Thread ZhenHua
On 04/23/2013 10:07 PM, Greg KH wrote: On Tue, Apr 23, 2013 at 03:15:01PM +0800, Li, Zhen-Hua wrote: From: "Li, Zhen-Hua" This patch is trying to fix bug QXCR1001261767. Sorry for the bug number. Please ignore this line. What is that bug number? Where can it be referenced? If you are goin

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-23 Thread Alan Stern
On Tue, 23 Apr 2013, Greg KH wrote: > On Tue, Apr 23, 2013 at 03:15:01PM +0800, Li, Zhen-Hua wrote: > > From: "Li, Zhen-Hua" > > > > This patch is trying to fix bug QXCR1001261767. > > What is that bug number? Where can it be referenced? If you are going > to put it in a public place (like a

Re: [PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-23 Thread Greg KH
On Tue, Apr 23, 2013 at 03:15:01PM +0800, Li, Zhen-Hua wrote: > From: "Li, Zhen-Hua" > > This patch is trying to fix bug QXCR1001261767. What is that bug number? Where can it be referenced? If you are going to put it in a public place (like a kernel changelog), it needs to be publicly accessib

[PATCH 1/1] driver,usb: Fix a warning in uhci-hcd driver

2013-04-23 Thread Li, Zhen-Hua
From: "Li, Zhen-Hua" This patch is trying to fix bug QXCR1001261767. On some HP platform, when usb driver inits the iLo Virtual USB Controller, there may be a warning "Controller not stopped yet!". It is because driver does not wait enough time. This patch adds more time waiting and retries. S