Re: [PATCH 1/1] driver/snd: es18xx driver should use udelay error

2014-04-14 Thread Takashi Iwai
At Mon, 14 Apr 2014 14:00:40 +0200, Clemens Ladisch wrote: > > Li, Zhen-Hua wrote: > > udelay with more than 2 may cause __bad_udelay. > > Use mdelay for instead. > > > > #ifdef AVOID_POPS > > /* Avoid pops */ > > -udelay(10); > > + mudelay(100); >

Re: [PATCH 1/1] driver/snd: es18xx driver should use udelay error

2014-04-14 Thread Clemens Ladisch
Li, Zhen-Hua wrote: > udelay with more than 2 may cause __bad_udelay. > Use mdelay for instead. > > #ifdef AVOID_POPS > /* Avoid pops */ > -udelay(10); > + mudelay(100); This will not compile. Please test with AVOID_POPS enabled. Regards,

[PATCH 1/1] driver/snd: es18xx driver should use udelay error

2014-04-14 Thread Li, Zhen-Hua
From: "Li, Zhen-Hua" udelay with more than 2 may cause __bad_udelay. Use mdelay for instead. Signed-off-by: Li, Zhen-Hua --- sound/isa/es18xx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/isa/es18xx.c b/sound/isa/es18xx.c index 1c16830..8d3a3b6

[PATCH 1/1] driver/snd: es18xx driver should use udelay error

2014-04-14 Thread Li, Zhen-Hua
From: Li, Zhen-Hua zhen-h...@hp.com udelay with more than 2 may cause __bad_udelay. Use mdelay for instead. Signed-off-by: Li, Zhen-Hua zhen-h...@hp.com --- sound/isa/es18xx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/isa/es18xx.c

Re: [PATCH 1/1] driver/snd: es18xx driver should use udelay error

2014-04-14 Thread Clemens Ladisch
Li, Zhen-Hua wrote: udelay with more than 2 may cause __bad_udelay. Use mdelay for instead. #ifdef AVOID_POPS /* Avoid pops */ -udelay(10); + mudelay(100); This will not compile. Please test with AVOID_POPS enabled. Regards, Clemens --

Re: [PATCH 1/1] driver/snd: es18xx driver should use udelay error

2014-04-14 Thread Takashi Iwai
At Mon, 14 Apr 2014 14:00:40 +0200, Clemens Ladisch wrote: Li, Zhen-Hua wrote: udelay with more than 2 may cause __bad_udelay. Use mdelay for instead. #ifdef AVOID_POPS /* Avoid pops */ -udelay(10); + mudelay(100); This will not