Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

2013-03-27 Thread Linus Walleij
On Mon, Mar 4, 2013 at 10:09 AM, Sachin Kamat wrote: > Use the newly introduced devm_ioremap_resource() instead of > devm_request_and_ioremap() which provides more consistent error handling. > > devm_ioremap_resource() provides its own error messages; so all explicit > error messages can be

Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

2013-03-27 Thread Linus Walleij
On Mon, Mar 4, 2013 at 10:09 AM, Sachin Kamat sachin.ka...@linaro.org wrote: Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error

Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

2013-03-14 Thread Sachin Kamat
Hi Linus, On 4 March 2013 22:38, Tony Prisk wrote: > On Mon, 2013-03-04 at 14:39 +0530, Sachin Kamat wrote: >> Use the newly introduced devm_ioremap_resource() instead of >> devm_request_and_ioremap() which provides more consistent error handling. >> >> devm_ioremap_resource() provides its own

Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

2013-03-14 Thread Sachin Kamat
Hi Linus, On 4 March 2013 22:38, Tony Prisk li...@prisktech.co.nz wrote: On Mon, 2013-03-04 at 14:39 +0530, Sachin Kamat wrote: Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource()

Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

2013-03-04 Thread Tony Prisk
On Mon, 2013-03-04 at 14:39 +0530, Sachin Kamat wrote: > Use the newly introduced devm_ioremap_resource() instead of > devm_request_and_ioremap() which provides more consistent error handling. > > devm_ioremap_resource() provides its own error messages; so all explicit > error messages can be

Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

2013-03-04 Thread Thierry Reding
On Mon, Mar 04, 2013 at 02:39:39PM +0530, Sachin Kamat wrote: > Use the newly introduced devm_ioremap_resource() instead of > devm_request_and_ioremap() which provides more consistent error handling. > > devm_ioremap_resource() provides its own error messages; so all explicit > error messages can

[PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

2013-03-04 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat

[PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

2013-03-04 Thread Sachin Kamat
Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed from the failure code paths. Signed-off-by: Sachin Kamat

Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

2013-03-04 Thread Thierry Reding
On Mon, Mar 04, 2013 at 02:39:39PM +0530, Sachin Kamat wrote: Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be

Re: [PATCH 1/1] gpio/vt8500: Convert to devm_ioremap_resource()

2013-03-04 Thread Tony Prisk
On Mon, 2013-03-04 at 14:39 +0530, Sachin Kamat wrote: Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages; so all explicit error messages can be removed