Re: [PATCH 1/1] iio: light: Added CM36672 Proximity Sensor Driver.

2016-05-29 Thread Jonathan Cameron
On 29/05/16 01:42, Kevin Tsai wrote: > Added Vishay Capella CM36672 Proximity Sensor IIO driver. Support both > ACPI and Device Tree. > > Signed-off-by: Kevin Tsai There are quite a few odd bits around the event handling. I think you failed to register the events

Re: [PATCH 1/1] iio: light: Added CM36672 Proximity Sensor Driver.

2016-05-29 Thread Jonathan Cameron
On 29/05/16 01:42, Kevin Tsai wrote: > Added Vishay Capella CM36672 Proximity Sensor IIO driver. Support both > ACPI and Device Tree. > > Signed-off-by: Kevin Tsai There are quite a few odd bits around the event handling. I think you failed to register the events properly then tried to work

Re: [PATCH 1/1] iio: light: Added CM36672 Proximity Sensor Driver.

2016-05-29 Thread Jonathan Cameron
On 29/05/16 09:55, Peter Meerwald-Stadler wrote: > On Sat, 28 May 2016, Kevin Tsai wrote: > >> Added Vishay Capella CM36672 Proximity Sensor IIO driver. Support both >> ACPI and Device Tree. > > comments below > >> Signed-off-by: Kevin Tsai >> --- >> +#ifdef

Re: [PATCH 1/1] iio: light: Added CM36672 Proximity Sensor Driver.

2016-05-29 Thread Jonathan Cameron
On 29/05/16 09:55, Peter Meerwald-Stadler wrote: > On Sat, 28 May 2016, Kevin Tsai wrote: > >> Added Vishay Capella CM36672 Proximity Sensor IIO driver. Support both >> ACPI and Device Tree. > > comments below > >> Signed-off-by: Kevin Tsai >> --- >> +#ifdef CONFIG_ACPI >> +/** >> + *

Re: [PATCH 1/1] iio: light: Added CM36672 Proximity Sensor Driver.

2016-05-29 Thread Peter Meerwald-Stadler
On Sat, 28 May 2016, Kevin Tsai wrote: > Added Vishay Capella CM36672 Proximity Sensor IIO driver. Support both > ACPI and Device Tree. comments below > Signed-off-by: Kevin Tsai > --- > .../devicetree/bindings/i2c/trivial-devices.txt| 1 + >

Re: [PATCH 1/1] iio: light: Added CM36672 Proximity Sensor Driver.

2016-05-29 Thread Peter Meerwald-Stadler
On Sat, 28 May 2016, Kevin Tsai wrote: > Added Vishay Capella CM36672 Proximity Sensor IIO driver. Support both > ACPI and Device Tree. comments below > Signed-off-by: Kevin Tsai > --- > .../devicetree/bindings/i2c/trivial-devices.txt| 1 + >

[PATCH 1/1] iio: light: Added CM36672 Proximity Sensor Driver.

2016-05-28 Thread Kevin Tsai
Added Vishay Capella CM36672 Proximity Sensor IIO driver. Support both ACPI and Device Tree. Signed-off-by: Kevin Tsai --- .../devicetree/bindings/i2c/trivial-devices.txt| 1 + .../devicetree/bindings/iio/light/cm36672.txt | 54 ++ MAINTAINERS

[PATCH 1/1] iio: light: Added CM36672 Proximity Sensor Driver.

2016-05-28 Thread Kevin Tsai
Added Vishay Capella CM36672 Proximity Sensor IIO driver. Support both ACPI and Device Tree. Signed-off-by: Kevin Tsai --- .../devicetree/bindings/i2c/trivial-devices.txt| 1 + .../devicetree/bindings/iio/light/cm36672.txt | 54 ++ MAINTAINERS