Re: [PATCH 1/1] irqchip/gicv3: iterate over possible CPUs by for_each_possible_cpu()

2017-09-15 Thread Marc Zyngier
On Fri, Sep 15 2017 at 11:05:25 am BST, zijun_hu wrote: > On 09/15/2017 03:20 AM, Marc Zyngier wrote: >> On Thu, Sep 14 2017 at 1:15:14 pm BST, zijun_hu wrote: >>> From: zijun_hu >>> >>> get_cpu_number() doesn't use existing helper to

Re: [PATCH 1/1] irqchip/gicv3: iterate over possible CPUs by for_each_possible_cpu()

2017-09-15 Thread Marc Zyngier
On Fri, Sep 15 2017 at 11:05:25 am BST, zijun_hu wrote: > On 09/15/2017 03:20 AM, Marc Zyngier wrote: >> On Thu, Sep 14 2017 at 1:15:14 pm BST, zijun_hu wrote: >>> From: zijun_hu >>> >>> get_cpu_number() doesn't use existing helper to iterate over possible >>> CPUs, so error happens in case of

Re: [PATCH 1/1] irqchip/gicv3: iterate over possible CPUs by for_each_possible_cpu()

2017-09-14 Thread zijun_hu
On 09/15/2017 03:20 AM, Marc Zyngier wrote: > On Thu, Sep 14 2017 at 1:15:14 pm BST, zijun_hu wrote: >> From: zijun_hu >> >> get_cpu_number() doesn't use existing helper to iterate over possible >> CPUs, so error happens in case of discontinuous

Re: [PATCH 1/1] irqchip/gicv3: iterate over possible CPUs by for_each_possible_cpu()

2017-09-14 Thread zijun_hu
On 09/15/2017 03:20 AM, Marc Zyngier wrote: > On Thu, Sep 14 2017 at 1:15:14 pm BST, zijun_hu wrote: >> From: zijun_hu >> >> get_cpu_number() doesn't use existing helper to iterate over possible >> CPUs, so error happens in case of discontinuous @cpu_possible_mask >> such as 0b0001. > > Do

Re: [PATCH 1/1] irqchip/gicv3: iterate over possible CPUs by for_each_possible_cpu()

2017-09-14 Thread Marc Zyngier
On Thu, Sep 14 2017 at 1:15:14 pm BST, zijun_hu wrote: > From: zijun_hu > > get_cpu_number() doesn't use existing helper to iterate over possible > CPUs, so error happens in case of discontinuous @cpu_possible_mask > such as 0b0001. Do you have an

Re: [PATCH 1/1] irqchip/gicv3: iterate over possible CPUs by for_each_possible_cpu()

2017-09-14 Thread Marc Zyngier
On Thu, Sep 14 2017 at 1:15:14 pm BST, zijun_hu wrote: > From: zijun_hu > > get_cpu_number() doesn't use existing helper to iterate over possible > CPUs, so error happens in case of discontinuous @cpu_possible_mask > such as 0b0001. Do you have an example of such a situation? Your patch is

[PATCH 1/1] irqchip/gicv3: iterate over possible CPUs by for_each_possible_cpu()

2017-09-13 Thread zijun_hu
From: zijun_hu get_cpu_number() doesn't use existing helper to iterate over possible CPUs, so error happens in case of discontinuous @cpu_possible_mask such as 0b0001. fixed by using existing helper for_each_possible_cpu(). Signed-off-by: zijun_hu ---

[PATCH 1/1] irqchip/gicv3: iterate over possible CPUs by for_each_possible_cpu()

2017-09-13 Thread zijun_hu
From: zijun_hu get_cpu_number() doesn't use existing helper to iterate over possible CPUs, so error happens in case of discontinuous @cpu_possible_mask such as 0b0001. fixed by using existing helper for_each_possible_cpu(). Signed-off-by: zijun_hu --- drivers/irqchip/irq-gic-v3.c | 8