Re: [PATCH 1/1] media: i2c: Add support for ov5693 sensor

2021-03-15 Thread Daniel Scally
Hi Laurent On 14/03/2021 23:29, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Fri, Mar 12, 2021 at 10:32:39AM +, Daniel Scally wrote: >> The OV5693 is a 5 Mpx CMOS image sensor, connected via MIPI CSI-2. The >> chip is capable of a single lane configuration, but

Re: [PATCH 1/1] media: i2c: Add support for ov5693 sensor

2021-03-14 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Fri, Mar 12, 2021 at 10:32:39AM +, Daniel Scally wrote: > The OV5693 is a 5 Mpx CMOS image sensor, connected via MIPI CSI-2. The > chip is capable of a single lane configuration, but currently only two > lanes are supported. > > Most of the sensor's

Re: [PATCH 1/1] media: i2c: Add support for ov5693 sensor

2021-03-14 Thread Daniel Scally
Hi Jacopo, thanks for the review On 14/03/2021 10:40, Jacopo Mondi wrote: >> +#define OV5693_REG_CHIP_ID_H0x300A >> +#define OV5693_REG_CHIP_ID_L0x300B > Please use lower case letters in hex identifiers Will do >> + >> +/* Miscellaneous */ >>

Re: [PATCH 1/1] media: i2c: Add support for ov5693 sensor

2021-03-14 Thread Jacopo Mondi
Hi Daniel, On Fri, Mar 12, 2021 at 10:32:39AM +, Daniel Scally wrote: > The OV5693 is a 5 Mpx CMOS image sensor, connected via MIPI CSI-2. The > chip is capable of a single lane configuration, but currently only two > lanes are supported. > > Most of the sensor's features are supported, with

[PATCH 1/1] media: i2c: Add support for ov5693 sensor

2021-03-12 Thread Daniel Scally
The OV5693 is a 5 Mpx CMOS image sensor, connected via MIPI CSI-2. The chip is capable of a single lane configuration, but currently only two lanes are supported. Most of the sensor's features are supported, with the main exception being the lens correction algorithm. The driver provides all