Re: [PATCH 1/1] mm: Inconsistent use of node IDs

2007-03-16 Thread Ethan Solomita
Ping! -- Ethan Ethan Solomita wrote: > Andi Kleen wrote: > >> On Monday 12 March 2007 23:51, Ethan Solomita wrote: >> >>> This patch corrects inconsistent use of node numbers (variously "nid" or >>> "node") in the presence of fake NUMA. >>> >> I think it's very consistent

Re: [PATCH 1/1] mm: Inconsistent use of node IDs

2007-03-16 Thread Ethan Solomita
Ping! -- Ethan Ethan Solomita wrote: Andi Kleen wrote: On Monday 12 March 2007 23:51, Ethan Solomita wrote: This patch corrects inconsistent use of node numbers (variously nid or node) in the presence of fake NUMA. I think it's very consistent -- your patch would

Re: [PATCH 1/1] mm: Inconsistent use of node IDs

2007-03-12 Thread Ethan Solomita
Andi Kleen wrote: On Monday 12 March 2007 23:51, Ethan Solomita wrote: This patch corrects inconsistent use of node numbers (variously "nid" or "node") in the presence of fake NUMA. I think it's very consistent -- your patch would make it inconsistent though. It's consistent to call

Re: [PATCH 1/1] mm: Inconsistent use of node IDs

2007-03-12 Thread Andi Kleen
On Monday 12 March 2007 23:51, Ethan Solomita wrote: > This patch corrects inconsistent use of node numbers (variously "nid" or > "node") in the presence of fake NUMA. I think it's very consistent -- your patch would make it inconsistent though. > Both AMD and Intel x86_64 discovery code will

[PATCH 1/1] mm: Inconsistent use of node IDs

2007-03-12 Thread Ethan Solomita
This patch corrects inconsistent use of node numbers (variously "nid" or "node") in the presence of fake NUMA. Both AMD and Intel x86_64 discovery code will determine a CPU's physical node and use that node when calling numa_add_cpu() to associate that CPU with the node, but numa_add_cpu()

[PATCH 1/1] mm: Inconsistent use of node IDs

2007-03-12 Thread Ethan Solomita
This patch corrects inconsistent use of node numbers (variously nid or node) in the presence of fake NUMA. Both AMD and Intel x86_64 discovery code will determine a CPU's physical node and use that node when calling numa_add_cpu() to associate that CPU with the node, but numa_add_cpu() treats

Re: [PATCH 1/1] mm: Inconsistent use of node IDs

2007-03-12 Thread Andi Kleen
On Monday 12 March 2007 23:51, Ethan Solomita wrote: This patch corrects inconsistent use of node numbers (variously nid or node) in the presence of fake NUMA. I think it's very consistent -- your patch would make it inconsistent though. Both AMD and Intel x86_64 discovery code will determine

Re: [PATCH 1/1] mm: Inconsistent use of node IDs

2007-03-12 Thread Ethan Solomita
Andi Kleen wrote: On Monday 12 March 2007 23:51, Ethan Solomita wrote: This patch corrects inconsistent use of node numbers (variously nid or node) in the presence of fake NUMA. I think it's very consistent -- your patch would make it inconsistent though. It's consistent to call