On Fri, 28 Feb 2014, Hugh Dickins wrote:
> On Fri, 28 Feb 2014, Ning Qu wrote:
>
> > In shmem/tmpfs, we also use the generic filemap_map_pages,
> > seems the additional checking is not worth a separate version
> > of map_pages for it.
> >
> > Signed-off-by: Ning Qu
Acked-by: Hugh Dickins
> >
On Fri, 28 Feb 2014, Hugh Dickins wrote:
On Fri, 28 Feb 2014, Ning Qu wrote:
In shmem/tmpfs, we also use the generic filemap_map_pages,
seems the additional checking is not worth a separate version
of map_pages for it.
Signed-off-by: Ning Qu qun...@google.com
Acked-by: Hugh Dickins
Thanks for the updates!
Best wishes,
--
Ning Qu (曲宁) | Software Engineer | qun...@google.com | +1-408-418-6066
On Mon, Mar 3, 2014 at 3:07 AM, Kirill A. Shutemov
wrote:
> Ning Qu wrote:
>> Btw, should we first check if page returned by radix_tree_deref_slot is NULL?
>
> Yes, we should. I don't
Ning Qu wrote:
> Btw, should we first check if page returned by radix_tree_deref_slot is NULL?
Yes, we should. I don't know how I missed that. :(
The patch below should address both issues.
>From dca24c9a1f31ee1599fe81e9a60d4f87a4eaf0ea Mon Sep 17 00:00:00 2001
From: "Kirill A. Shutemov"
Date:
Ning Qu wrote:
Btw, should we first check if page returned by radix_tree_deref_slot is NULL?
Yes, we should. I don't know how I missed that. :(
The patch below should address both issues.
From dca24c9a1f31ee1599fe81e9a60d4f87a4eaf0ea Mon Sep 17 00:00:00 2001
From: Kirill A. Shutemov
Thanks for the updates!
Best wishes,
--
Ning Qu (曲宁) | Software Engineer | qun...@google.com | +1-408-418-6066
On Mon, Mar 3, 2014 at 3:07 AM, Kirill A. Shutemov
kirill.shute...@linux.intel.com wrote:
Ning Qu wrote:
Btw, should we first check if page returned by radix_tree_deref_slot is NULL?
Btw, should we first check if page returned by radix_tree_deref_slot is NULL?
diff --git a/mm/filemap.c b/mm/filemap.c
index 1bc12a9..c129ee5 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1745,6 +1745,8 @@ void filemap_map_pages(struct vm_area_struct
*vma, struct vm_fault *vmf)
On Fri, 28 Feb 2014, Ning Qu wrote:
> In shmem/tmpfs, we also use the generic filemap_map_pages,
> seems the additional checking is not worth a separate version
> of map_pages for it.
>
> Signed-off-by: Ning Qu
> ---
> mm/shmem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
In shmem/tmpfs, we also use the generic filemap_map_pages,
seems the additional checking is not worth a separate version
of map_pages for it.
Signed-off-by: Ning Qu
---
mm/shmem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/shmem.c b/mm/shmem.c
index 1f18c9d..2ea4e89 100644
---
In shmem/tmpfs, we also use the generic filemap_map_pages,
seems the additional checking is not worth a separate version
of map_pages for it.
Signed-off-by: Ning Qu qun...@google.com
---
mm/shmem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/shmem.c b/mm/shmem.c
index 1f18c9d..2ea4e89
On Fri, 28 Feb 2014, Ning Qu wrote:
In shmem/tmpfs, we also use the generic filemap_map_pages,
seems the additional checking is not worth a separate version
of map_pages for it.
Signed-off-by: Ning Qu qun...@google.com
---
mm/shmem.c | 1 +
1 file changed, 1 insertion(+)
diff --git
Btw, should we first check if page returned by radix_tree_deref_slot is NULL?
diff --git a/mm/filemap.c b/mm/filemap.c
index 1bc12a9..c129ee5 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1745,6 +1745,8 @@ void filemap_map_pages(struct vm_area_struct
*vma, struct vm_fault *vmf)
12 matches
Mail list logo