Re: [PATCH 1/1] mm: implement ->map_pages for shmem/tmpfs

2014-03-04 Thread Hugh Dickins
On Fri, 28 Feb 2014, Hugh Dickins wrote: > On Fri, 28 Feb 2014, Ning Qu wrote: > > > In shmem/tmpfs, we also use the generic filemap_map_pages, > > seems the additional checking is not worth a separate version > > of map_pages for it. > > > > Signed-off-by: Ning Qu Acked-by: Hugh Dickins > >

Re: [PATCH 1/1] mm: implement -map_pages for shmem/tmpfs

2014-03-04 Thread Hugh Dickins
On Fri, 28 Feb 2014, Hugh Dickins wrote: On Fri, 28 Feb 2014, Ning Qu wrote: In shmem/tmpfs, we also use the generic filemap_map_pages, seems the additional checking is not worth a separate version of map_pages for it. Signed-off-by: Ning Qu qun...@google.com Acked-by: Hugh Dickins

Re: [PATCH 1/1] mm: implement ->map_pages for shmem/tmpfs

2014-03-03 Thread Ning Qu
Thanks for the updates! Best wishes, -- Ning Qu (曲宁) | Software Engineer | qun...@google.com | +1-408-418-6066 On Mon, Mar 3, 2014 at 3:07 AM, Kirill A. Shutemov wrote: > Ning Qu wrote: >> Btw, should we first check if page returned by radix_tree_deref_slot is NULL? > > Yes, we should. I don't

Re: [PATCH 1/1] mm: implement ->map_pages for shmem/tmpfs

2014-03-03 Thread Kirill A. Shutemov
Ning Qu wrote: > Btw, should we first check if page returned by radix_tree_deref_slot is NULL? Yes, we should. I don't know how I missed that. :( The patch below should address both issues. >From dca24c9a1f31ee1599fe81e9a60d4f87a4eaf0ea Mon Sep 17 00:00:00 2001 From: "Kirill A. Shutemov" Date:

Re: [PATCH 1/1] mm: implement -map_pages for shmem/tmpfs

2014-03-03 Thread Kirill A. Shutemov
Ning Qu wrote: Btw, should we first check if page returned by radix_tree_deref_slot is NULL? Yes, we should. I don't know how I missed that. :( The patch below should address both issues. From dca24c9a1f31ee1599fe81e9a60d4f87a4eaf0ea Mon Sep 17 00:00:00 2001 From: Kirill A. Shutemov

Re: [PATCH 1/1] mm: implement -map_pages for shmem/tmpfs

2014-03-03 Thread Ning Qu
Thanks for the updates! Best wishes, -- Ning Qu (曲宁) | Software Engineer | qun...@google.com | +1-408-418-6066 On Mon, Mar 3, 2014 at 3:07 AM, Kirill A. Shutemov kirill.shute...@linux.intel.com wrote: Ning Qu wrote: Btw, should we first check if page returned by radix_tree_deref_slot is NULL?

Re: [PATCH 1/1] mm: implement ->map_pages for shmem/tmpfs

2014-02-28 Thread Ning Qu
Btw, should we first check if page returned by radix_tree_deref_slot is NULL? diff --git a/mm/filemap.c b/mm/filemap.c index 1bc12a9..c129ee5 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1745,6 +1745,8 @@ void filemap_map_pages(struct vm_area_struct *vma, struct vm_fault *vmf)

Re: [PATCH 1/1] mm: implement ->map_pages for shmem/tmpfs

2014-02-28 Thread Hugh Dickins
On Fri, 28 Feb 2014, Ning Qu wrote: > In shmem/tmpfs, we also use the generic filemap_map_pages, > seems the additional checking is not worth a separate version > of map_pages for it. > > Signed-off-by: Ning Qu > --- > mm/shmem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

[PATCH 1/1] mm: implement ->map_pages for shmem/tmpfs

2014-02-28 Thread Ning Qu
In shmem/tmpfs, we also use the generic filemap_map_pages, seems the additional checking is not worth a separate version of map_pages for it. Signed-off-by: Ning Qu --- mm/shmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/shmem.c b/mm/shmem.c index 1f18c9d..2ea4e89 100644 ---

[PATCH 1/1] mm: implement -map_pages for shmem/tmpfs

2014-02-28 Thread Ning Qu
In shmem/tmpfs, we also use the generic filemap_map_pages, seems the additional checking is not worth a separate version of map_pages for it. Signed-off-by: Ning Qu qun...@google.com --- mm/shmem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/shmem.c b/mm/shmem.c index 1f18c9d..2ea4e89

Re: [PATCH 1/1] mm: implement -map_pages for shmem/tmpfs

2014-02-28 Thread Hugh Dickins
On Fri, 28 Feb 2014, Ning Qu wrote: In shmem/tmpfs, we also use the generic filemap_map_pages, seems the additional checking is not worth a separate version of map_pages for it. Signed-off-by: Ning Qu qun...@google.com --- mm/shmem.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH 1/1] mm: implement -map_pages for shmem/tmpfs

2014-02-28 Thread Ning Qu
Btw, should we first check if page returned by radix_tree_deref_slot is NULL? diff --git a/mm/filemap.c b/mm/filemap.c index 1bc12a9..c129ee5 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -1745,6 +1745,8 @@ void filemap_map_pages(struct vm_area_struct *vma, struct vm_fault *vmf)