Re: [PATCH 1/1] module: fix sprintf format specifier in param_get_byte()

2013-08-07 Thread Jon Mason
On Wed, Aug 07, 2013 at 04:13:57PM +0930, Rusty Russell wrote: > Christoph Jaeger writes: > > In param_get_byte(), to which the macro STANDARD_PARAM_DEF(byte, ...) > > expands, > > "%c" is used to print an unsigned char. So it gets printed as a character > > what > > is not intended here. Use "%

Re: [PATCH 1/1] module: fix sprintf format specifier in param_get_byte()

2013-08-07 Thread Michal Nazarewicz
On Wed, Aug 07 2013, Rusty Russell wrote: > Christoph Jaeger writes: >> In param_get_byte(), to which the macro STANDARD_PARAM_DEF(byte, ...) >> expands, >> "%c" is used to print an unsigned char. So it gets printed as a character >> what >> is not intended here. Use "%hhu" instead. >> >> Signed

Re: [PATCH 1/1] module: fix sprintf format specifier in param_get_byte()

2013-08-07 Thread Rusty Russell
Christoph Jaeger writes: > In param_get_byte(), to which the macro STANDARD_PARAM_DEF(byte, ...) expands, > "%c" is used to print an unsigned char. So it gets printed as a character what > is not intended here. Use "%hhu" instead. > > Signed-off-by: Christoph Jaeger Nice patch. Unfortunately, t

Re: [PATCH 1/1] module: fix sprintf format specifier in param_get_byte()

2013-08-06 Thread Joe Perches
On Tue, 2013-08-06 at 23:12 +0200, Christoph Jaeger wrote: > In param_get_byte(), to which the macro STANDARD_PARAM_DEF(byte, ...) expands, > "%c" is used to print an unsigned char. So it gets printed as a character what > is not intended here. Use "%hhu" instead. > > Signed-off-by: Christoph Jaeg

[PATCH 1/1] module: fix sprintf format specifier in param_get_byte()

2013-08-06 Thread Christoph Jaeger
In param_get_byte(), to which the macro STANDARD_PARAM_DEF(byte, ...) expands, "%c" is used to print an unsigned char. So it gets printed as a character what is not intended here. Use "%hhu" instead. Signed-off-by: Christoph Jaeger --- kernel/params.c | 2 +- 1 file changed, 1 insertion(+), 1 de