On Wed, 2014-04-16 at 15:08 +0800, Li, Zhen-Hua wrote:
> From: "Li, Zhen-Hua"
>
> As netif_running is called in netif_device_attach/detach. There should be
> rtnl_lock/unlock called, to avoid dev stat change during netif_device_attach
> and detach being called.
> I checked NIC some drivers,
On Wed, 2014-04-16 at 15:08 +0800, Li, Zhen-Hua wrote:
From: Li, Zhen-Hua zhen-h...@hp.com
As netif_running is called in netif_device_attach/detach. There should be
rtnl_lock/unlock called, to avoid dev stat change during netif_device_attach
and detach being called.
I checked NIC some
Hello.
On 21-04-2014 10:30, Li, ZhenHua wrote:
The comment is trying to explain why add a lock here.
I can read, thanks. :-)
I was wondering about the kernel-doc comment style you've used; AFAIK,
it's only good for documenting functions and data structures. The normal
multi-line
The comment is trying to explain why add a lock here.
On 04/19/2014 03:01 AM, Sergei Shtylyov wrote:
Hello.
On 04/16/2014 11:08 AM, Li, Zhen-Hua wrote:
From: "Li, Zhen-Hua"
As netif_running is called in netif_device_attach/detach. There
should be
rtnl_lock/unlock called, to avoid dev
The comment is trying to explain why add a lock here.
On 04/19/2014 03:01 AM, Sergei Shtylyov wrote:
Hello.
On 04/16/2014 11:08 AM, Li, Zhen-Hua wrote:
From: Li, Zhen-Hua zhen-h...@hp.com
As netif_running is called in netif_device_attach/detach. There
should be
rtnl_lock/unlock called, to
Hello.
On 21-04-2014 10:30, Li, ZhenHua wrote:
The comment is trying to explain why add a lock here.
I can read, thanks. :-)
I was wondering about the kernel-doc comment style you've used; AFAIK,
it's only good for documenting functions and data structures. The normal
multi-line
Hello.
On 04/16/2014 11:08 AM, Li, Zhen-Hua wrote:
From: "Li, Zhen-Hua"
As netif_running is called in netif_device_attach/detach. There should be
rtnl_lock/unlock called, to avoid dev stat change during netif_device_attach
and detach being called.
I checked NIC some drivers, some of them
Hello.
On 04/16/2014 11:08 AM, Li, Zhen-Hua wrote:
From: Li, Zhen-Hua zhen-h...@hp.com
As netif_running is called in netif_device_attach/detach. There should be
rtnl_lock/unlock called, to avoid dev stat change during netif_device_attach
and detach being called.
I checked NIC some drivers,
The problem I am trying to fix is: when netif_device_attach/detached is
called, it get a return value from netif_running, but at this moment, in
another thread, the stat of this dev changes. But in
netif_device_attach, it does not know stat changed, and this may cause bugs.
I think you are
On Wed, Apr 16, 2014 at 03:08:02PM +0800, Li, Zhen-Hua wrote:
From: "Li, Zhen-Hua"
As netif_running is called in netif_device_attach/detach. There should be
rtnl_lock/unlock called, to avoid dev stat change during netif_device_attach
and detach being called.
I checked NIC some drivers, some
From: "Li, Zhen-Hua"
As netif_running is called in netif_device_attach/detach. There should be
rtnl_lock/unlock called, to avoid dev stat change during netif_device_attach
and detach being called.
I checked NIC some drivers, some of them have netif_device_attach/detach
called between
From: Li, Zhen-Hua zhen-h...@hp.com
As netif_running is called in netif_device_attach/detach. There should be
rtnl_lock/unlock called, to avoid dev stat change during netif_device_attach
and detach being called.
I checked NIC some drivers, some of them have netif_device_attach/detach
called
On Wed, Apr 16, 2014 at 03:08:02PM +0800, Li, Zhen-Hua wrote:
From: Li, Zhen-Hua zhen-h...@hp.com
As netif_running is called in netif_device_attach/detach. There should be
rtnl_lock/unlock called, to avoid dev stat change during netif_device_attach
and detach being called.
I checked NIC some
The problem I am trying to fix is: when netif_device_attach/detached is
called, it get a return value from netif_running, but at this moment, in
another thread, the stat of this dev changes. But in
netif_device_attach, it does not know stat changed, and this may cause bugs.
I think you are
14 matches
Mail list logo
