Re: [PATCH 1/1] netfilter: Deletion of unnecessary checks before two function calls

On Thu, Nov 20, 2014 at 10:13:59AM +0900, Simon Horman wrote: > On Thu, Nov 20, 2014 at 12:26:56AM +0200, Julian Anastasov wrote: > > > > Hello, > > > > On Tue, 18 Nov 2014, SF Markus Elfring wrote: > > > > > From: Markus Elfring > > > Date: Tue, 18 Nov 2014 20:37:05 +0100 > > > > > > The

Re: [PATCH 1/1] netfilter: Deletion of unnecessary checks before two function calls

On Thu, Nov 20, 2014 at 12:26:56AM +0200, Julian Anastasov wrote: > > Hello, > > On Tue, 18 Nov 2014, SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Tue, 18 Nov 2014 20:37:05 +0100 > > > > The functions free_percpu() and module_put() test whether their argument > > is NULL

Re: [PATCH 1/1] netfilter: Deletion of unnecessary checks before two function calls

Hello, On Tue, 18 Nov 2014, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 18 Nov 2014 20:37:05 +0100 > > The functions free_percpu() and module_put() test whether their argument > is NULL and then return immediately. Thus the test around the call is > not needed. > > Th

Re: [PATCH 1/1] netfilter: Deletion of unnecessary checks before two function calls

On Tue, Nov 18, 2014 at 08:47:31PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 18 Nov 2014 20:37:05 +0100 > > The functions free_percpu() and module_put() test whether their argument > is NULL and then return immediately. Thus the test around the call is > not needed. @IP

[PATCH 1/1] netfilter: Deletion of unnecessary checks before two function calls

From: Markus Elfring Date: Tue, 18 Nov 2014 20:37:05 +0100 The functions free_percpu() and module_put() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus E