Re: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format

2020-06-17 Thread Christoph Hellwig
Applied to nvme-5.9.

Re: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format

2020-06-10 Thread Dongli Zhang
Hi Christoph, Would you mind apply this one with the Reviewed-by from James and Sagi? https://lore.kernel.org/linux-nvme/60df6752-3512-f7a9-b0df-1096b93b8...@broadcom.com/ https://lore.kernel.org/linux-nvme/c4ec2d9e-b08c-19b2-16a5-93520ca13...@grimberg.me/ Thank you very much! Dongli Zhang

Re: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format

2020-06-04 Thread Sagi Grimberg
Reviewed-by: Sagi Grimberg

Re: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format

2020-06-04 Thread James Smart
On 5/25/2020 9:21 PM, Dongli Zhang wrote: The nvme host and target verify the wwnn and wwpn format via nvme_fc_parse_traddr(). For instance, it is required that the length of wwnn to be either 21 ("nn-0x") or 19 (nn-). Add this verification to nvme-fcloop so that the input should always be in

Re: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format

2020-06-04 Thread Hannes Reinecke
On 6/4/20 8:54 AM, Chaitanya Kulkarni wrote: On 6/3/20 11:46 PM, Dongli Zhang wrote: May I get feedback for this? For the first time I use fcloop, I set: # echo "wwnn=0x3,wwpn=0x1" > /sys/class/fcloop/ctl/add_target_port However, I would not be able to move forward if I use "0x3" or "0x1"

Re: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format

2020-06-04 Thread Chaitanya Kulkarni
On 6/3/20 11:46 PM, Dongli Zhang wrote: > May I get feedback for this? > > For the first time I use fcloop, I set: > > # echo "wwnn=0x3,wwpn=0x1" > /sys/class/fcloop/ctl/add_target_port > > However, I would not be able to move forward if I use "0x3" or "0x1" for > nvme-fc > target or host

Re: [PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format

2020-06-04 Thread Dongli Zhang
May I get feedback for this? For the first time I use fcloop, I set: # echo "wwnn=0x3,wwpn=0x1" > /sys/class/fcloop/ctl/add_target_port However, I would not be able to move forward if I use "0x3" or "0x1" for nvme-fc target or host further. Instead, the address and port should be

[PATCH 1/1] nvme-fcloop: verify wwnn and wwpn format

2020-05-25 Thread Dongli Zhang
The nvme host and target verify the wwnn and wwpn format via nvme_fc_parse_traddr(). For instance, it is required that the length of wwnn to be either 21 ("nn-0x") or 19 (nn-). Add this verification to nvme-fcloop so that the input should always be in hex and the length of input should always be