Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-18 Thread Alan Cox
On Mon, Sep 17, 2007 at 01:46:01PM +0200, Tejun Heo wrote: > failures and would really like to know what's broken. The reason can be > one of the following two. > > 1. libata itself isn't doing anything wrong but using SCSI for mid and > high level drivers are causing problems as more types of

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-18 Thread Alan Cox
On Mon, Sep 17, 2007 at 07:00:03AM +0200, Tejun Heo wrote: > I wonder whether we should be using similar check in generic path too. > We have quite a few cases where MWDMA ATAPI devices choking on commands > with small transfer sizes. I don't think we'll experience significant > performance

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-18 Thread Alan Cox
On Mon, Sep 17, 2007 at 07:00:03AM +0200, Tejun Heo wrote: I wonder whether we should be using similar check in generic path too. We have quite a few cases where MWDMA ATAPI devices choking on commands with small transfer sizes. I don't think we'll experience significant performance

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-18 Thread Alan Cox
On Mon, Sep 17, 2007 at 01:46:01PM +0200, Tejun Heo wrote: failures and would really like to know what's broken. The reason can be one of the following two. 1. libata itself isn't doing anything wrong but using SCSI for mid and high level drivers are causing problems as more types of

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-17 Thread Tejun Heo
Jeff Garzik wrote: > Tejun Heo wrote: >> [cc'ing Albert and linux-ide] >> >> Alan Cox wrote: >>> /from the media. */ > +if (qc->nbytes < 2048) > +return -EOPNOTSUPP; > + > /* No ATAPI DMA in smart mode */ > if (itdev->smart) >

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-17 Thread Jeff Garzik
Tejun Heo wrote: [cc'ing Albert and linux-ide] Alan Cox wrote: /from the media. */ > + if (qc->nbytes < 2048) > + return -EOPNOTSUPP; > + > /* No ATAPI DMA in smart mode */ > if (itdev->smart) > return -EOPNOTSUPP; > This looks like a gross hack. Aren't you

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-17 Thread Tejun Heo
[cc'ing Albert and linux-ide] Alan Cox wrote: > /from the media. */ >> > + if (qc->nbytes < 2048) >> > + return -EOPNOTSUPP; >> > + >> > /* No ATAPI DMA in smart mode */ >> > if (itdev->smart) >> > return -EOPNOTSUPP; >> > >> >> This looks like a gross hack. Aren't

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-17 Thread Tejun Heo
[cc'ing Albert and linux-ide] Alan Cox wrote: /from the media. */ + if (qc-nbytes 2048) + return -EOPNOTSUPP; + /* No ATAPI DMA in smart mode */ if (itdev-smart) return -EOPNOTSUPP; This looks like a gross hack. Aren't you supposed to inspect the

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-17 Thread Jeff Garzik
Tejun Heo wrote: [cc'ing Albert and linux-ide] Alan Cox wrote: /from the media. */ + if (qc-nbytes 2048) + return -EOPNOTSUPP; + /* No ATAPI DMA in smart mode */ if (itdev-smart) return -EOPNOTSUPP; This looks like a gross hack. Aren't you supposed to

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-17 Thread Tejun Heo
Jeff Garzik wrote: Tejun Heo wrote: [cc'ing Albert and linux-ide] Alan Cox wrote: /from the media. */ +if (qc-nbytes 2048) +return -EOPNOTSUPP; + /* No ATAPI DMA in smart mode */ if (itdev-smart) return -EOPNOTSUPP; This looks like a gross

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-10 Thread Jeff Garzik
Jeff Norden wrote: From: Jeff Norden <[EMAIL PROTECTED]> Fix "lost" interrupt problem when using dma with CD/DVD drives in some configurations. This problem can make installing linux from media impossible for distro's that have switched to libata-only configurations. The simple fix is to

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-10 Thread Jeff Garzik
Jeff Norden wrote: From: Jeff Norden [EMAIL PROTECTED] Fix lost interrupt problem when using dma with CD/DVD drives in some configurations. This problem can make installing linux from media impossible for distro's that have switched to libata-only configurations. The simple fix is to

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-05 Thread Alan Cox
/from the media. */ > > + if (qc->nbytes < 2048) > > + return -EOPNOTSUPP; > > + > >/* No ATAPI DMA in smart mode */ > >if (itdev->smart) > >return -EOPNOTSUPP; > > > > This looks like a gross hack. Aren't you supposed to inspect > the command instead and

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-05 Thread Alan Cox
/from the media. */ + if (qc-nbytes 2048) + return -EOPNOTSUPP; + /* No ATAPI DMA in smart mode */ if (itdev-smart) return -EOPNOTSUPP; This looks like a gross hack. Aren't you supposed to inspect the command instead and whitelist the ones you

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-04 Thread Mikael Pettersson
Jeff Norden writes: > From: Jeff Norden <[EMAIL PROTECTED]> > > Fix "lost" interrupt problem when using dma with CD/DVD drives in some > configurations. This problem can make installing linux from media > impossible for distro's that have switched to libata-only configurations. > > The

[PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-04 Thread Jeff Norden
From: Jeff Norden <[EMAIL PROTECTED]> Fix "lost" interrupt problem when using dma with CD/DVD drives in some configurations. This problem can make installing linux from media impossible for distro's that have switched to libata-only configurations. The simple fix is to eliminate the use of dma

[PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-04 Thread Jeff Norden
From: Jeff Norden [EMAIL PROTECTED] Fix lost interrupt problem when using dma with CD/DVD drives in some configurations. This problem can make installing linux from media impossible for distro's that have switched to libata-only configurations. The simple fix is to eliminate the use of dma for

Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

2007-09-04 Thread Mikael Pettersson
Jeff Norden writes: From: Jeff Norden [EMAIL PROTECTED] Fix lost interrupt problem when using dma with CD/DVD drives in some configurations. This problem can make installing linux from media impossible for distro's that have switched to libata-only configurations. The simple fix