Re: [PATCH 1/1] pcmcia: Add missing free_irq()

2015-06-14 Thread Takeshi Yoshimura
Hi, >> index 965bd84..7922e30f 100644 >> --- a/drivers/pcmcia/yenta_socket.c >> +++ b/drivers/pcmcia/yenta_socket.c >> @@ -1269,6 +1269,8 @@ static int yenta_probe(struct pci_dev *dev, const >> struct pci_device_id *id) >> pcmcia_unregister_socket(>socket); >> } >> >> +

Re: [PATCH 1/1] pcmcia: Add missing free_irq()

2015-06-14 Thread Dominik Brodowski
Hi Takeshi, On Sun, Jun 14, 2015 at 09:14:41PM +0900, Takeshi Yoshimura wrote: > In yenta_probe(), an irq leak potentially happens when > pcmcia_register_socket() fails. I added the missed call. nice catch, many thanks. > index 965bd84..7922e30f 100644 > --- a/drivers/pcmcia/yenta_socket.c >

[PATCH 1/1] pcmcia: Add missing free_irq()

2015-06-14 Thread Takeshi Yoshimura
In yenta_probe(), an irq leak potentially happens when pcmcia_register_socket() fails. I added the missed call. Signed-off-by: Takeshi Yoshimura --- drivers/pcmcia/yenta_socket.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pcmcia/yenta_socket.c b/drivers/pcmcia/yenta_socket.c

Re: [PATCH 1/1] pcmcia: Add missing free_irq()

2015-06-14 Thread Dominik Brodowski
Hi Takeshi, On Sun, Jun 14, 2015 at 09:14:41PM +0900, Takeshi Yoshimura wrote: In yenta_probe(), an irq leak potentially happens when pcmcia_register_socket() fails. I added the missed call. nice catch, many thanks. index 965bd84..7922e30f 100644 --- a/drivers/pcmcia/yenta_socket.c +++

[PATCH 1/1] pcmcia: Add missing free_irq()

2015-06-14 Thread Takeshi Yoshimura
In yenta_probe(), an irq leak potentially happens when pcmcia_register_socket() fails. I added the missed call. Signed-off-by: Takeshi Yoshimura y...@sslab.ics.keio.ac.jp --- drivers/pcmcia/yenta_socket.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pcmcia/yenta_socket.c

Re: [PATCH 1/1] pcmcia: Add missing free_irq()

2015-06-14 Thread Takeshi Yoshimura
Hi, index 965bd84..7922e30f 100644 --- a/drivers/pcmcia/yenta_socket.c +++ b/drivers/pcmcia/yenta_socket.c @@ -1269,6 +1269,8 @@ static int yenta_probe(struct pci_dev *dev, const struct pci_device_id *id) pcmcia_unregister_socket(socket-socket); } + if