RE: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-06-06 Thread Shenwei Wang
Hi Thierry, Thank you for the detailed review. I was intending to avoid adding a new compatible string, and to limit the changes. But your comments make sense, and I will split the commit and use the compatible string to identify the IP differences. Thanks, Shenwei -Original Message-

RE: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-06-06 Thread Shenwei Wang
Hi Thierry, Thank you for the detailed review. I was intending to avoid adding a new compatible string, and to limit the changes. But your comments make sense, and I will split the commit and use the compatible string to identify the IP differences. Thanks, Shenwei -Original Message-

Re: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-06-06 Thread Thierry Reding
On Thu, May 24, 2018 at 01:08:48PM -0500, shenwei.w...@nxp.com wrote: > On the new i.MX8x SoC family, the following changes were made on the FTM > block: > > 1. Need to enable the IPG clock before accessing any FTM registers. Because > the IPG clock is not an option for FTM counter clock source,

Re: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-06-06 Thread Thierry Reding
On Thu, May 24, 2018 at 01:08:48PM -0500, shenwei.w...@nxp.com wrote: > On the new i.MX8x SoC family, the following changes were made on the FTM > block: > > 1. Need to enable the IPG clock before accessing any FTM registers. Because > the IPG clock is not an option for FTM counter clock source,

RE: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-06-05 Thread Shenwei Wang
Hello Thierry, Can you please share your comments on the patch? Thanks, Shenwei -Original Message- From: Shenwei Wang Sent: Wednesday, May 30, 2018 12:00 PM To: thierry.red...@gmail.com Cc: linux-...@vger.kernel.org; dl-linux-imx ; linux-kernel@vger.kernel.org Subject: RE: [PATCH 1/1]

RE: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-06-05 Thread Shenwei Wang
Hello Thierry, Can you please share your comments on the patch? Thanks, Shenwei -Original Message- From: Shenwei Wang Sent: Wednesday, May 30, 2018 12:00 PM To: thierry.red...@gmail.com Cc: linux-...@vger.kernel.org; dl-linux-imx ; linux-kernel@vger.kernel.org Subject: RE: [PATCH 1/1]

RE: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-05-30 Thread Shenwei Wang
Ping. Shenwei -Original Message- From: Shenwei Wang Sent: Thursday, May 24, 2018 1:09 PM To: thierry.red...@gmail.com Cc: linux-...@vger.kernel.org; dl-linux-imx ; linux-kernel@vger.kernel.org; Shenwei Wang Subject: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on

RE: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-05-30 Thread Shenwei Wang
Ping. Shenwei -Original Message- From: Shenwei Wang Sent: Thursday, May 24, 2018 1:09 PM To: thierry.red...@gmail.com Cc: linux-...@vger.kernel.org; dl-linux-imx ; linux-kernel@vger.kernel.org; Shenwei Wang Subject: [PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on

[PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-05-30 Thread shenwei . wang
On the new i.MX8x SoC family, the following changes were made on the FTM block: 1. Need to enable the IPG clock before accessing any FTM registers. Because the IPG clock is not an option for FTM counter clock source, it can't be used as the ftm_sys clock. 2. An additional PWM enable bit was

[PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-05-30 Thread shenwei . wang
On the new i.MX8x SoC family, the following changes were made on the FTM block: 1. Need to enable the IPG clock before accessing any FTM registers. Because the IPG clock is not an option for FTM counter clock source, it can't be used as the ftm_sys clock. 2. An additional PWM enable bit was

[PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-05-24 Thread shenwei . wang
On the new i.MX8x SoC family, the following changes were made on the FTM block: 1. Need to enable the IPG clock before accessing any FTM registers. Because the IPG clock is not an option for FTM counter clock source, it can't be used as the ftm_sys clock. 2. An additional PWM enable bit was

[PATCH 1/1] pwm: fsl-ftm: Support the new version of FTM block on i.MX8x

2018-05-24 Thread shenwei . wang
On the new i.MX8x SoC family, the following changes were made on the FTM block: 1. Need to enable the IPG clock before accessing any FTM registers. Because the IPG clock is not an option for FTM counter clock source, it can't be used as the ftm_sys clock. 2. An additional PWM enable bit was