Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

2014-03-02 Thread Joe Perches
On Sun, 2014-03-02 at 21:51 +0530, Yogesh Chaudhari wrote: > I will send in a new patch with both the script file and the > documentation modifications. Separate patches please. Changes to CodingStyle generally bring another round of comments. -- To unsubscribe from this list: send the line "uns

Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

2014-03-02 Thread Yogesh Chaudhari
On 2 March 2014 21:19, Levente Kurusa wrote: > Hi, > > 2014-03-02 16:40 GMT+01:00 Joe Perches : >> On Sun, 2014-03-02 at 16:20 +0100, Levente Kurusa wrote: >>> IMHO, this message is too big. The one we already have is nice and clean. >>> I would simply do: s/netdev/[subsystem]/ or something among

Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

2014-03-02 Thread Levente Kurusa
Hi, 2014-03-02 16:40 GMT+01:00 Joe Perches : > On Sun, 2014-03-02 at 16:20 +0100, Levente Kurusa wrote: >> IMHO, this message is too big. The one we already have is nice and clean. >> I would simply do: s/netdev/[subsystem]/ or something among the lines. > > maybe: > > "Prefer [subsystem eg: netde

Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

2014-03-02 Thread Joe Perches
On Sun, 2014-03-02 at 16:20 +0100, Levente Kurusa wrote: > IMHO, this message is too big. The one we already have is nice and clean. > I would simply do: s/netdev/[subsystem]/ or something among the lines. maybe: "Prefer [subsystem eg: netdev]_$level2 then dev_$level2 then pr_$level to printk(KE

Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

2014-03-02 Thread Levente Kurusa
Hi, [+CC LKML, Joe] [Leaving full copy for LKML, Joe] On 03/02/2014 04:29 PM, Yogesh Chaudhari wrote: > On 2 March 2014 20:50, Levente Kurusa wrote: >> Hi, >> >> On 03/02/2014 04:01 PM, Yogesh Chaudhari wrote: >>> Based on the discussion here: >>> https://lkml.org/lkml/2014/3/2/17 >>> >>> I woul

Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

2014-03-02 Thread Levente Kurusa
Hi, On 03/02/2014 04:01 PM, Yogesh Chaudhari wrote: > Based on the discussion here: > https://lkml.org/lkml/2014/3/2/17 > > I would like to propose this patch to improve the warning message in > checkpatch.pl. Comments/Suggestions on possible improvements are > welcome. > > > =

Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

2014-03-02 Thread Joe Perches
On Sun, 2014-03-02 at 20:31 +0530, Yogesh Chaudhari wrote: > Based on the discussion here: > https://lkml.org/lkml/2014/3/2/17 > > I would like to propose this patch to improve the warning message in > checkpatch.pl. Comments/Suggestions on possible improvements are > welcome. Messages are all s

[PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch

2014-03-02 Thread Yogesh Chaudhari
Based on the discussion here: https://lkml.org/lkml/2014/3/2/17 I would like to propose this patch to improve the warning message in checkpatch.pl. Comments/Suggestions on possible improvements are welcome. = This patch modifies scripts/c