Re: [PATCH 1/1] selinux: fix double free

2020-06-10 Thread Tom Rix
>> +++ b/security/selinux/ss/services.c >> @@ -2888,8 +2888,12 @@ int security_get_bools(struct selinux_state *state, >> if (*names) { >> for (i = 0; i < *len; i++) >> kfree((*names)[i]); >> + kfree(names); > kfree(*names)? Yes. >

Re: [PATCH 1/1] selinux: fix double free

2020-06-10 Thread Stephen Smalley
On Wed, Jun 10, 2020 at 2:10 PM wrote: > > From: Tom Rix > > Clang's static analysis tool reports these double free memory errors. > > security/selinux/ss/services.c:2987:4: warning: Attempt to free released > memory [unix.Malloc] > kfree(bnames[i]); >

[PATCH 1/1] selinux: fix double free

2020-06-10 Thread trix
From: Tom Rix Clang's static analysis tool reports these double free memory errors. security/selinux/ss/services.c:2987:4: warning: Attempt to free released memory [unix.Malloc] kfree(bnames[i]); ^~~~