Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-27 Thread Vinayak Menon
On 11/24/2017 7:00 PM, Vaneet Narang wrote: > Hi Michal, > >>>  We have been getting similar kind of such entries and eventually >>>  stackdepot reaches Max Cap. So we found this interface useful in debugging >>>  stackdepot issue so shared in community. >   >> Then use it for internal debugging 

Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-27 Thread Vinayak Menon
On 11/24/2017 7:00 PM, Vaneet Narang wrote: > Hi Michal, > >>>  We have been getting similar kind of such entries and eventually >>>  stackdepot reaches Max Cap. So we found this interface useful in debugging >>>  stackdepot issue so shared in community. >   >> Then use it for internal debugging 

Re: Re: Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-24 Thread Michal Hocko
On Fri 24-11-17 13:30:25, Vaneet Narang wrote: > Hi Michal, > > >> We have been getting similar kind of such entries and eventually > >> stackdepot reaches Max Cap. So we found this interface useful in debugging > >> stackdepot issue so shared in community. >   > >Then use it for internal 

Re: Re: Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-24 Thread Michal Hocko
On Fri 24-11-17 13:30:25, Vaneet Narang wrote: > Hi Michal, > > >> We have been getting similar kind of such entries and eventually > >> stackdepot reaches Max Cap. So we found this interface useful in debugging > >> stackdepot issue so shared in community. >   > >Then use it for internal 

RE: Re: Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-24 Thread Vaneet Narang
Hi Michal, >> We have been getting similar kind of such entries and eventually >> stackdepot reaches Max Cap. So we found this interface useful in debugging >> stackdepot issue so shared in community.   >Then use it for internal debugging and provide a code which would scale >better on smaller 

RE: Re: Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-24 Thread Vaneet Narang
Hi Michal, >> We have been getting similar kind of such entries and eventually >> stackdepot reaches Max Cap. So we found this interface useful in debugging >> stackdepot issue so shared in community.   >Then use it for internal debugging and provide a code which would scale >better on smaller 

Re: Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-24 Thread Michal Hocko
On Fri 24-11-17 11:57:07, Vaneet Narang wrote: [...] > > OK, so debugging a debugging facility... I do not think we want to > > introduce a lot of code for something like that. > > We enabled stackdepot on our system and realised, in long run stack depot > consumes > more runtime memory then it

Re: Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-24 Thread Michal Hocko
On Fri 24-11-17 11:57:07, Vaneet Narang wrote: [...] > > OK, so debugging a debugging facility... I do not think we want to > > introduce a lot of code for something like that. > > We enabled stackdepot on our system and realised, in long run stack depot > consumes > more runtime memory then it

RE: Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-24 Thread Vaneet Narang
Hi Michal, >> 5) To check number of entries in stackdepot to decide stackdepot hash size >> for different systems. >>For fewer entries hash table size can be reduced from 4MB. > > What are you going to do with that information. It is not like you can > reduce the memory footprint or somehow

RE: Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-24 Thread Vaneet Narang
Hi Michal, >> 5) To check number of entries in stackdepot to decide stackdepot hash size >> for different systems. >>For fewer entries hash table size can be reduced from 4MB. > > What are you going to do with that information. It is not like you can > reduce the memory footprint or somehow

Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-24 Thread Dmitry Vyukov
On Fri, Nov 24, 2017 at 10:54 AM, Michal Hocko wrote: > On Fri 24-11-17 09:41:08, Maninder Singh wrote: >> Hi Michal, >> >> > On Wed 22-11-17 16:17:41, Maninder Singh wrote: >> > > This patch provides interface to check all the stack enteries >> > > saved in stackdepot so far

Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-24 Thread Dmitry Vyukov
On Fri, Nov 24, 2017 at 10:54 AM, Michal Hocko wrote: > On Fri 24-11-17 09:41:08, Maninder Singh wrote: >> Hi Michal, >> >> > On Wed 22-11-17 16:17:41, Maninder Singh wrote: >> > > This patch provides interface to check all the stack enteries >> > > saved in stackdepot so far as well as memory

Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-24 Thread Michal Hocko
On Fri 24-11-17 09:41:08, Maninder Singh wrote: > Hi Michal, > > > On Wed 22-11-17 16:17:41, Maninder Singh wrote: > > > This patch provides interface to check all the stack enteries > > > saved in stackdepot so far as well as memory consumed by stackdepot. > > > > > > 1) Take current

Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-24 Thread Michal Hocko
On Fri 24-11-17 09:41:08, Maninder Singh wrote: > Hi Michal, > > > On Wed 22-11-17 16:17:41, Maninder Singh wrote: > > > This patch provides interface to check all the stack enteries > > > saved in stackdepot so far as well as memory consumed by stackdepot. > > > > > > 1) Take current

Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-24 Thread Maninder Singh
Hi Michal, > On Wed 22-11-17 16:17:41, Maninder Singh wrote: > > This patch provides interface to check all the stack enteries > > saved in stackdepot so far as well as memory consumed by stackdepot. > > > > 1) Take current depot_index and offset to calculate end address for one > >

Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-24 Thread Maninder Singh
Hi Michal, > On Wed 22-11-17 16:17:41, Maninder Singh wrote: > > This patch provides interface to check all the stack enteries > > saved in stackdepot so far as well as memory consumed by stackdepot. > > > > 1) Take current depot_index and offset to calculate end address for one > >

Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-23 Thread Michal Hocko
On Wed 22-11-17 16:17:41, Maninder Singh wrote: > This patch provides interface to check all the stack enteries > saved in stackdepot so far as well as memory consumed by stackdepot. > > 1) Take current depot_index and offset to calculate end address for one > iteration of

Re: [PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-23 Thread Michal Hocko
On Wed 22-11-17 16:17:41, Maninder Singh wrote: > This patch provides interface to check all the stack enteries > saved in stackdepot so far as well as memory consumed by stackdepot. > > 1) Take current depot_index and offset to calculate end address for one > iteration of

[PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-22 Thread Maninder Singh
This patch provides interface to check all the stack enteries saved in stackdepot so far as well as memory consumed by stackdepot. 1) Take current depot_index and offset to calculate end address for one iteration of (/sys/kernel/debug/depot_stack/depot_entries). 2) Fill end marker in

[PATCH 1/1] stackdepot: interface to check entries and size of stackdepot.

2017-11-22 Thread Maninder Singh
This patch provides interface to check all the stack enteries saved in stackdepot so far as well as memory consumed by stackdepot. 1) Take current depot_index and offset to calculate end address for one iteration of (/sys/kernel/debug/depot_stack/depot_entries). 2) Fill end marker in