Re: [PATCH 1/1] staging: ti-soc-thermal: remove usage of IS_ERR_OR_NULL

2013-04-25 Thread Eduardo Valentin
Russell, Thanks for your time reviewing this patch. On 25-04-2013 13:44, Russell King wrote: On Thu, Apr 25, 2013 at 09:46:16AM -0400, Eduardo Valentin wrote: diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.c b/drivers/staging/ti-soc-thermal/ti-bandgap.c index f20c1cf..5027833 100644

Re: [PATCH 1/1] staging: ti-soc-thermal: remove usage of IS_ERR_OR_NULL

2013-04-25 Thread Russell King
On Thu, Apr 25, 2013 at 09:46:16AM -0400, Eduardo Valentin wrote: > diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.c > b/drivers/staging/ti-soc-thermal/ti-bandgap.c > index f20c1cf..5027833 100644 > --- a/drivers/staging/ti-soc-thermal/ti-bandgap.c > +++

[PATCH 1/1] staging: ti-soc-thermal: remove usage of IS_ERR_OR_NULL

2013-04-25 Thread Eduardo Valentin
This patch changes the driver to avoid the usage of IS_ERR_OR_NULL() macro. This macro can lead to dangerous results, like returning success (0) during a failure scenario (NULL pointer handling). For this reason this patch is changing the driver after revisiting the code. These are the cases: i.

[PATCH 1/1] staging: ti-soc-thermal: remove usage of IS_ERR_OR_NULL

2013-04-25 Thread Eduardo Valentin
This patch changes the driver to avoid the usage of IS_ERR_OR_NULL() macro. This macro can lead to dangerous results, like returning success (0) during a failure scenario (NULL pointer handling). For this reason this patch is changing the driver after revisiting the code. These are the cases: i.

Re: [PATCH 1/1] staging: ti-soc-thermal: remove usage of IS_ERR_OR_NULL

2013-04-25 Thread Russell King
On Thu, Apr 25, 2013 at 09:46:16AM -0400, Eduardo Valentin wrote: diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.c b/drivers/staging/ti-soc-thermal/ti-bandgap.c index f20c1cf..5027833 100644 --- a/drivers/staging/ti-soc-thermal/ti-bandgap.c +++

Re: [PATCH 1/1] staging: ti-soc-thermal: remove usage of IS_ERR_OR_NULL

2013-04-25 Thread Eduardo Valentin
Russell, Thanks for your time reviewing this patch. On 25-04-2013 13:44, Russell King wrote: On Thu, Apr 25, 2013 at 09:46:16AM -0400, Eduardo Valentin wrote: diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.c b/drivers/staging/ti-soc-thermal/ti-bandgap.c index f20c1cf..5027833 100644