Re: [PATCH 1/1] uio: Fix uio_device memory leak

2017-06-13 Thread Greg KH
On Tue, Jun 13, 2017 at 07:35:51PM -0500, Mike Christie wrote: > On 06/13/2017 07:16 PM, Mike Christie wrote: > > On 06/13/2017 09:01 AM, Greg KH wrote: > >> > On Wed, Jun 07, 2017 at 03:06:44PM -0500, Mike Christie wrote: > >>> >> It looks like there might be 2 issues with the uio_device

Re: [PATCH 1/1] uio: Fix uio_device memory leak

2017-06-13 Thread Greg KH
On Tue, Jun 13, 2017 at 07:35:51PM -0500, Mike Christie wrote: > On 06/13/2017 07:16 PM, Mike Christie wrote: > > On 06/13/2017 09:01 AM, Greg KH wrote: > >> > On Wed, Jun 07, 2017 at 03:06:44PM -0500, Mike Christie wrote: > >>> >> It looks like there might be 2 issues with the uio_device

Re: [PATCH 1/1] uio: Fix uio_device memory leak

2017-06-13 Thread Mike Christie
On 06/13/2017 07:16 PM, Mike Christie wrote: > On 06/13/2017 09:01 AM, Greg KH wrote: >> > On Wed, Jun 07, 2017 at 03:06:44PM -0500, Mike Christie wrote: >>> >> It looks like there might be 2 issues with the uio_device allocation, or >>> >> it >>> >> looks like we are leaking the device for

Re: [PATCH 1/1] uio: Fix uio_device memory leak

2017-06-13 Thread Mike Christie
On 06/13/2017 07:16 PM, Mike Christie wrote: > On 06/13/2017 09:01 AM, Greg KH wrote: >> > On Wed, Jun 07, 2017 at 03:06:44PM -0500, Mike Christie wrote: >>> >> It looks like there might be 2 issues with the uio_device allocation, or >>> >> it >>> >> looks like we are leaking the device for

Re: [PATCH 1/1] uio: Fix uio_device memory leak

2017-06-13 Thread Mike Christie
On 06/13/2017 09:01 AM, Greg KH wrote: > On Wed, Jun 07, 2017 at 03:06:44PM -0500, Mike Christie wrote: >> It looks like there might be 2 issues with the uio_device allocation, or it >> looks like we are leaking the device for possibly a specific type of device >> case that I could not find but

Re: [PATCH 1/1] uio: Fix uio_device memory leak

2017-06-13 Thread Mike Christie
On 06/13/2017 09:01 AM, Greg KH wrote: > On Wed, Jun 07, 2017 at 03:06:44PM -0500, Mike Christie wrote: >> It looks like there might be 2 issues with the uio_device allocation, or it >> looks like we are leaking the device for possibly a specific type of device >> case that I could not find but

Re: [PATCH 1/1] uio: Fix uio_device memory leak

2017-06-13 Thread Greg KH
On Wed, Jun 07, 2017 at 03:06:44PM -0500, Mike Christie wrote: > It looks like there might be 2 issues with the uio_device allocation, or it > looks like we are leaking the device for possibly a specific type of device > case that I could not find but one of you may know about. > > Issues: > 1.

Re: [PATCH 1/1] uio: Fix uio_device memory leak

2017-06-13 Thread Greg KH
On Wed, Jun 07, 2017 at 03:06:44PM -0500, Mike Christie wrote: > It looks like there might be 2 issues with the uio_device allocation, or it > looks like we are leaking the device for possibly a specific type of device > case that I could not find but one of you may know about. > > Issues: > 1.

[PATCH 1/1] uio: Fix uio_device memory leak

2017-06-07 Thread Mike Christie
It looks like there might be 2 issues with the uio_device allocation, or it looks like we are leaking the device for possibly a specific type of device case that I could not find but one of you may know about. Issues: 1. We use devm_kzalloc to allocate the uio_device, but the release function,

[PATCH 1/1] uio: Fix uio_device memory leak

2017-06-07 Thread Mike Christie
It looks like there might be 2 issues with the uio_device allocation, or it looks like we are leaking the device for possibly a specific type of device case that I could not find but one of you may know about. Issues: 1. We use devm_kzalloc to allocate the uio_device, but the release function,