Re: [PATCH 1/1] unify queue_delayed_work and queue_delayed_work_on fix

2007-02-16 Thread Oleg Nesterov
On 02/16, Jiri Slaby wrote: > > unify queue_delayed_work and queue_delayed_work_on fix > > Since cwq->wq is unset for other than singlethread_cpu when singlethread > workqueue was created, an oops occurs during bootup. And I thought I tested this... >

Re: [PATCH 1/1] unify queue_delayed_work and queue_delayed_work_on fix

2007-02-16 Thread Oleg Nesterov
On 02/16, Jiri Slaby wrote: unify queue_delayed_work and queue_delayed_work_on fix Since cwq-wq is unset for other than singlethread_cpu when singlethread workqueue was created, an oops occurs during bootup. And I thought I tested this...

Re: [PATCH 1/1] unify queue_delayed_work and queue_delayed_work_on fix

2007-02-15 Thread Jiri Slaby
Jiri Slaby napsal(a): [...] unify queue_delayed_work and queue_delayed_work_on fix Oh sorry, the name should be make queue_delayed_work() friendly to flush_fork() fix Since cwq->wq is unset for other than singlethread_cpu when singlethread workqueue was created, an oops occurs during bootup.

[PATCH 1/1] unify queue_delayed_work and queue_delayed_work_on fix

2007-02-15 Thread Jiri Slaby
Andrew Morton wrote: > Temporarily at > > http://userweb.kernel.org/~akpm/2.6.20-mm1/ [...] > +unify-queue_delayed_work-and-queue_delayed_work_on.patch I'm getting oops in delayed_work_timer_fn, since cwq->wq is NULL and accessed there. The patch below fixes the problem for me. -- unify

[PATCH 1/1] unify queue_delayed_work and queue_delayed_work_on fix

2007-02-15 Thread Jiri Slaby
Andrew Morton wrote: Temporarily at http://userweb.kernel.org/~akpm/2.6.20-mm1/ [...] +unify-queue_delayed_work-and-queue_delayed_work_on.patch I'm getting oops in delayed_work_timer_fn, since cwq-wq is NULL and accessed there. The patch below fixes the problem for me. -- unify

Re: [PATCH 1/1] unify queue_delayed_work and queue_delayed_work_on fix

2007-02-15 Thread Jiri Slaby
Jiri Slaby napsal(a): [...] unify queue_delayed_work and queue_delayed_work_on fix Oh sorry, the name should be make queue_delayed_work() friendly to flush_fork() fix Since cwq-wq is unset for other than singlethread_cpu when singlethread workqueue was created, an oops occurs during bootup.