Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v3

2007-09-24 Thread Dave Jones
On Tue, Sep 25, 2007 at 02:20:01AM +0200, roel wrote: > > > > if ((c->x86_vendor != X86_VENDOR_AMD) || (c->x86 != 5) || > > > > ((c->x86_model != 12) && (c->x86_model != 13))) > > > > > > while we're at it, we could change this to > > > > > > if

Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v3

2007-09-24 Thread roel
Dave Jones wrote: > to add a single line reply> Ok, sorry, I don't know these rules > On Tue, Sep 25, 2007 at 12:01:56AM +0200, roel wrote: > > > > --- a/arch/i386/kernel/cpu/cpufreq/powernow-k6.c > > > +++ b/arch/i386/kernel/cpu/cpufreq/powernow-k6.c > > > @@ -215,7 +215,7 @@ static

Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v3

2007-09-24 Thread Dave Jones
On Tue, Sep 25, 2007 at 12:01:56AM +0200, roel wrote: > > --- a/arch/i386/kernel/cpu/cpufreq/powernow-k6.c > > +++ b/arch/i386/kernel/cpu/cpufreq/powernow-k6.c > > @@ -215,7 +215,7 @@ static struct cpufreq_driver powernow_k6 > > */ > > static int __init powernow_k6_init(void) > > { >

Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v3

2007-09-24 Thread roel
[EMAIL PROTECTED] wrote: > v3: fix compile errors in arch-i386-allmodconfig build > > v2: rebasing on 2.6.23-rc6-mm1 > > cpu_data is currently an array defined using NR_CPUS. This means that > we overallocate since we will rarely really use maximum configured cpus. > When NR_CPU count is raised

[PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v3

2007-09-24 Thread travis
v3: fix compile errors in arch-i386-allmodconfig build v2: rebasing on 2.6.23-rc6-mm1 cpu_data is currently an array defined using NR_CPUS. This means that we overallocate since we will rarely really use maximum configured cpus. When NR_CPU count is raised to 4096 the size of cpu_data becomes

[PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v3

2007-09-24 Thread travis
v3: fix compile errors in arch-i386-allmodconfig build v2: rebasing on 2.6.23-rc6-mm1 cpu_data is currently an array defined using NR_CPUS. This means that we overallocate since we will rarely really use maximum configured cpus. When NR_CPU count is raised to 4096 the size of cpu_data becomes

Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v3

2007-09-24 Thread roel
[EMAIL PROTECTED] wrote: v3: fix compile errors in arch-i386-allmodconfig build v2: rebasing on 2.6.23-rc6-mm1 cpu_data is currently an array defined using NR_CPUS. This means that we overallocate since we will rarely really use maximum configured cpus. When NR_CPU count is raised to 4096

Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v3

2007-09-24 Thread Dave Jones
excessive quoting trimmed, please don't quote 40K of text to add a single line reply On Tue, Sep 25, 2007 at 12:01:56AM +0200, roel wrote: --- a/arch/i386/kernel/cpu/cpufreq/powernow-k6.c +++ b/arch/i386/kernel/cpu/cpufreq/powernow-k6.c @@ -215,7 +215,7 @@ static struct cpufreq_driver

Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v3

2007-09-24 Thread roel
Dave Jones wrote: excessive quoting trimmed, please don't quote 40K of text to add a single line reply Ok, sorry, I don't know these rules On Tue, Sep 25, 2007 at 12:01:56AM +0200, roel wrote: --- a/arch/i386/kernel/cpu/cpufreq/powernow-k6.c +++

Re: [PATCH 1/1] x86: Convert cpuinfo_x86 array to a per_cpu array v3

2007-09-24 Thread Dave Jones
On Tue, Sep 25, 2007 at 02:20:01AM +0200, roel wrote: if ((c-x86_vendor != X86_VENDOR_AMD) || (c-x86 != 5) || ((c-x86_model != 12) (c-x86_model != 13))) while we're at it, we could change this to if (!(c-x86_vendor == X86_VENDOR_AMD