Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size

2015-11-18 Thread Christoph Hellwig
On Fri, Nov 13, 2015 at 03:08:11PM +, Keith Busch wrote: > On Thu, Nov 12, 2015 at 11:37:54PM -0800, Christoph Hellwig wrote: > > Jens, Keith: any chance to get this to Linux for 4.4 (and -stable)? > > I agreed, looks good to me. > > Acked-by: Keith Busch Jens, can you pick this one for

Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size

2015-11-18 Thread Christoph Hellwig
On Fri, Nov 13, 2015 at 03:08:11PM +, Keith Busch wrote: > On Thu, Nov 12, 2015 at 11:37:54PM -0800, Christoph Hellwig wrote: > > Jens, Keith: any chance to get this to Linux for 4.4 (and -stable)? > > I agreed, looks good to me. > > Acked-by: Keith Busch Jens, can

Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size

2015-11-13 Thread Keith Busch
On Thu, Nov 12, 2015 at 11:37:54PM -0800, Christoph Hellwig wrote: > Jens, Keith: any chance to get this to Linux for 4.4 (and -stable)? I agreed, looks good to me. Acked-by: Keith Busch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size

2015-11-13 Thread Keith Busch
On Thu, Nov 12, 2015 at 11:37:54PM -0800, Christoph Hellwig wrote: > Jens, Keith: any chance to get this to Linux for 4.4 (and -stable)? I agreed, looks good to me. Acked-by: Keith Busch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size

2015-11-12 Thread Christoph Hellwig
Jens, Keith: any chance to get this to Linux for 4.4 (and -stable)? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size

2015-11-12 Thread Christoph Hellwig
Jens, Keith: any chance to get this to Linux for 4.4 (and -stable)? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size

2015-11-06 Thread Nishanth Aravamudan
On 05.11.2015 [11:58:39 -0800], Christoph Hellwig wrote: > Looks fine, > > Reviewed-by: Christoph Hellwig > > ... but I doubt we'll ever bother updating it. Most architectures > with arger page sizes also have iommus and would need different settings > for different iommus vs direct mapping

Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size

2015-11-06 Thread Nishanth Aravamudan
On 05.11.2015 [11:58:39 -0800], Christoph Hellwig wrote: > Looks fine, > > Reviewed-by: Christoph Hellwig > > ... but I doubt we'll ever bother updating it. Most architectures > with arger page sizes also have iommus and would need different settings > for different iommus vs

Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size

2015-11-05 Thread Nishanth Aravamudan
On 05.11.2015 [11:58:39 -0800], Christoph Hellwig wrote: > Looks fine, > > Reviewed-by: Christoph Hellwig > > ... but I doubt we'll ever bother updating it. Most architectures > with arger page sizes also have iommus and would need different settings > for different iommus vs direct mapping

Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size

2015-11-05 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig ... but I doubt we'll ever bother updating it. Most architectures with arger page sizes also have iommus and would need different settings for different iommus vs direct mapping for very little gain. There's a reason why we never bothered for RDMA

[PATCH 1/1 v4] drivers/nvme: default to 4k device page size

2015-11-05 Thread Nishanth Aravamudan
On 03.11.2015 [13:46:25 +], Keith Busch wrote: > On Tue, Nov 03, 2015 at 05:18:24AM -0800, Christoph Hellwig wrote: > > On Fri, Oct 30, 2015 at 02:35:11PM -0700, Nishanth Aravamudan wrote: > > > diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c > > > index

[PATCH 1/1 v4] drivers/nvme: default to 4k device page size

2015-11-05 Thread Nishanth Aravamudan
On 03.11.2015 [13:46:25 +], Keith Busch wrote: > On Tue, Nov 03, 2015 at 05:18:24AM -0800, Christoph Hellwig wrote: > > On Fri, Oct 30, 2015 at 02:35:11PM -0700, Nishanth Aravamudan wrote: > > > diff --git a/drivers/block/nvme-core.c b/drivers/block/nvme-core.c > > > index

Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size

2015-11-05 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig ... but I doubt we'll ever bother updating it. Most architectures with arger page sizes also have iommus and would need different settings for different iommus vs direct mapping for very little gain. There's a reason why we never

Re: [PATCH 1/1 v4] drivers/nvme: default to 4k device page size

2015-11-05 Thread Nishanth Aravamudan
On 05.11.2015 [11:58:39 -0800], Christoph Hellwig wrote: > Looks fine, > > Reviewed-by: Christoph Hellwig > > ... but I doubt we'll ever bother updating it. Most architectures > with arger page sizes also have iommus and would need different settings > for different iommus vs