Re: [PATCH 1/13] speedtch: Clean up printk()'s in drivers/usb/atm/speedtch.c

2005-03-07 Thread Greg KH
On Sun, Mar 06, 2005 at 07:18:41AM -0500, Jim Nelson wrote: > Any other tips on how the usb printk()s should be formatted to maintain > consistency? Or some driver that I could use as an example? Use dev_dbg() and friends. That is the proper consistency. thanks, greg k-h - To unsubscribe from

Re: [PATCH 1/13] speedtch: Clean up printk()'s in drivers/usb/atm/speedtch.c

2005-03-07 Thread Greg KH
On Sun, Mar 06, 2005 at 07:18:41AM -0500, Jim Nelson wrote: Any other tips on how the usb printk()s should be formatted to maintain consistency? Or some driver that I could use as an example? Use dev_dbg() and friends. That is the proper consistency. thanks, greg k-h - To unsubscribe from

Re: [PATCH 1/13] speedtch: Clean up printk()'s in drivers/usb/atm/speedtch.c

2005-03-06 Thread Jim Nelson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Greg KH wrote: | On Sat, Mar 05, 2005 at 05:37:13PM -0600, James Nelson wrote: | |>Add a KERN_WARNING constant to a printk() that is missing it, and add a driver |>prefix to another two in drivers/usb/atm/speedtch.c | | | Please CC: usb patches to the

Re: [PATCH 1/13] speedtch: Clean up printk()'s in drivers/usb/atm/speedtch.c

2005-03-06 Thread Jim Nelson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Greg KH wrote: | On Sat, Mar 05, 2005 at 05:37:13PM -0600, James Nelson wrote: | |Add a KERN_WARNING constant to a printk() that is missing it, and add a driver |prefix to another two in drivers/usb/atm/speedtch.c | | | Please CC: usb patches to the

Re: [PATCH 1/13] speedtch: Clean up printk()'s in drivers/usb/atm/speedtch.c

2005-03-05 Thread Greg KH
On Sat, Mar 05, 2005 at 05:37:13PM -0600, James Nelson wrote: > Add a KERN_WARNING constant to a printk() that is missing it, and add a driver > prefix to another two in drivers/usb/atm/speedtch.c Please CC: usb patches to the usb maintainer, it makes it a bit hard for him to apply them otherwise

[PATCH 1/13] speedtch: Clean up printk()'s in drivers/usb/atm/speedtch.c

2005-03-05 Thread James Nelson
Add a KERN_WARNING constant to a printk() that is missing it, and add a driver prefix to another two in drivers/usb/atm/speedtch.c Signed-off-by: James Nelson <[EMAIL PROTECTED]> diff -Nurp -x dontdiff-osdl --exclude='*~' linux-2.6.11-mm1-original/drivers/usb/atm/speedtch.c

[PATCH 1/13] speedtch: Clean up printk()'s in drivers/usb/atm/speedtch.c

2005-03-05 Thread James Nelson
Add a KERN_WARNING constant to a printk() that is missing it, and add a driver prefix to another two in drivers/usb/atm/speedtch.c Signed-off-by: James Nelson [EMAIL PROTECTED] diff -Nurp -x dontdiff-osdl --exclude='*~' linux-2.6.11-mm1-original/drivers/usb/atm/speedtch.c

Re: [PATCH 1/13] speedtch: Clean up printk()'s in drivers/usb/atm/speedtch.c

2005-03-05 Thread Greg KH
On Sat, Mar 05, 2005 at 05:37:13PM -0600, James Nelson wrote: Add a KERN_WARNING constant to a printk() that is missing it, and add a driver prefix to another two in drivers/usb/atm/speedtch.c Please CC: usb patches to the usb maintainer, it makes it a bit hard for him to apply them otherwise