Re: [PATCH 1/2] [media] mantis: Move jump label to activate dead code

2015-02-17 Thread Silvan Jegen
Thanks for the review, Dan! On Mon, Feb 16, 2015 at 10:04 AM, Dan Carpenter wrote: > On Sun, Feb 15, 2015 at 01:11:04PM +0100, Silvan Jegen wrote: >> diff --git a/drivers/media/pci/mantis/mantis_cards.c >> b/drivers/media/pci/mantis/mantis_cards.c >> index 801fc55..e566061 100644 >> ---

Re: [PATCH 1/2] [media] mantis: Move jump label to activate dead code

2015-02-17 Thread Silvan Jegen
Thanks for the review, Dan! On Mon, Feb 16, 2015 at 10:04 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Sun, Feb 15, 2015 at 01:11:04PM +0100, Silvan Jegen wrote: diff --git a/drivers/media/pci/mantis/mantis_cards.c b/drivers/media/pci/mantis/mantis_cards.c index 801fc55..e566061

Re: [PATCH 1/2] [media] mantis: Move jump label to activate dead code

2015-02-16 Thread Dan Carpenter
On Sun, Feb 15, 2015 at 01:11:04PM +0100, Silvan Jegen wrote: > diff --git a/drivers/media/pci/mantis/mantis_cards.c > b/drivers/media/pci/mantis/mantis_cards.c > index 801fc55..e566061 100644 > --- a/drivers/media/pci/mantis/mantis_cards.c > +++ b/drivers/media/pci/mantis/mantis_cards.c > @@

Re: [PATCH 1/2] [media] mantis: Move jump label to activate dead code

2015-02-16 Thread Dan Carpenter
On Sun, Feb 15, 2015 at 01:11:04PM +0100, Silvan Jegen wrote: diff --git a/drivers/media/pci/mantis/mantis_cards.c b/drivers/media/pci/mantis/mantis_cards.c index 801fc55..e566061 100644 --- a/drivers/media/pci/mantis/mantis_cards.c +++ b/drivers/media/pci/mantis/mantis_cards.c @@ -215,10

[PATCH 1/2] [media] mantis: Move jump label to activate dead code

2015-02-15 Thread Silvan Jegen
Due to a misplaced goto label mantis_uart_exit is never called. Adjusting the label position (while correcting its numbering) changes this. This issue was found using the smatch static checker. Signed-off-by: Silvan Jegen --- drivers/media/pci/mantis/mantis_cards.c | 5 +++-- 1 file changed,

[PATCH 1/2] [media] mantis: Move jump label to activate dead code

2015-02-15 Thread Silvan Jegen
Due to a misplaced goto label mantis_uart_exit is never called. Adjusting the label position (while correcting its numbering) changes this. This issue was found using the smatch static checker. Signed-off-by: Silvan Jegen s.je...@gmail.com --- drivers/media/pci/mantis/mantis_cards.c | 5 +++--