Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during init

2016-03-30 Thread Lorenzo Pieralisi
On Wed, Mar 30, 2016 at 10:09:12AM +0200, Daniel Lezcano wrote: > On 03/30/2016 09:16 AM, Jisheng Zhang wrote: > >Hi Daniel, > > [ ... ] > > Added Lorenzo and Catalin. > > >>Hi Jisheng, > >> > >>this should be handled in the arm_cpuidle_read_ops function. > >> > > > >Thanks for reviewing. After

Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during init

2016-03-30 Thread Jisheng Zhang
Hi Daniel, On Wed, 30 Mar 2016 11:31:39 +0200 Daniel Lezcano wrote: > On 03/30/2016 10:43 AM, Jisheng Zhang wrote: > > On Wed, 30 Mar 2016 10:41:09 +0200 Daniel Lezcano wrote: > > > >> On 03/30/2016 10:17 AM, Jisheng Zhang wrote: > >>> On Wed, 30 Mar 2016 10:09:12 +0200 Daniel Lezcano wrote:

Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during init

2016-03-30 Thread Daniel Lezcano
On 03/30/2016 10:43 AM, Jisheng Zhang wrote: On Wed, 30 Mar 2016 10:41:09 +0200 Daniel Lezcano wrote: On 03/30/2016 10:17 AM, Jisheng Zhang wrote: On Wed, 30 Mar 2016 10:09:12 +0200 Daniel Lezcano wrote: On 03/30/2016 09:16 AM, Jisheng Zhang wrote: Hi Daniel, [ ... ] Added Lorenzo and Ca

Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during init

2016-03-30 Thread Jisheng Zhang
On Wed, 30 Mar 2016 10:41:09 +0200 Daniel Lezcano wrote: > On 03/30/2016 10:17 AM, Jisheng Zhang wrote: > > On Wed, 30 Mar 2016 10:09:12 +0200 Daniel Lezcano wrote: > > > >> On 03/30/2016 09:16 AM, Jisheng Zhang wrote: > >>> Hi Daniel, > >> > >> [ ... ] > >> > >> Added Lorenzo and Catalin. >

Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during init

2016-03-30 Thread Daniel Lezcano
On 03/30/2016 10:17 AM, Jisheng Zhang wrote: On Wed, 30 Mar 2016 10:09:12 +0200 Daniel Lezcano wrote: On 03/30/2016 09:16 AM, Jisheng Zhang wrote: Hi Daniel, [ ... ] Added Lorenzo and Catalin. Hi Jisheng, this should be handled in the arm_cpuidle_read_ops function. Thanks for reviewin

Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during init

2016-03-30 Thread Jisheng Zhang
On Wed, 30 Mar 2016 10:09:12 +0200 Daniel Lezcano wrote: > On 03/30/2016 09:16 AM, Jisheng Zhang wrote: > > Hi Daniel, > > [ ... ] > > Added Lorenzo and Catalin. > > >> Hi Jisheng, > >> > >> this should be handled in the arm_cpuidle_read_ops function. > >> > > > > Thanks for reviewing. Afte

Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during init

2016-03-30 Thread Daniel Lezcano
On 03/30/2016 09:16 AM, Jisheng Zhang wrote: Hi Daniel, [ ... ] Added Lorenzo and Catalin. Hi Jisheng, this should be handled in the arm_cpuidle_read_ops function. Thanks for reviewing. After some consideration, I think this patch isn't correct There may be platforms which doesn't need t

Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during init

2016-03-30 Thread Jisheng Zhang
Hi Daniel, On Fri, 25 Mar 2016 12:46:10 +0100 Daniel Lezcano wrote: > On 03/24/2016 06:11 AM, Jisheng Zhang wrote: > > Let's assume cpuidle_ops exists but it doesn't implement the according > > init member, current arm_cpuidle_init() will return success to its > > caller, but in fact it should re

Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during init

2016-03-25 Thread Daniel Lezcano
On 03/24/2016 06:11 AM, Jisheng Zhang wrote: Let's assume cpuidle_ops exists but it doesn't implement the according init member, current arm_cpuidle_init() will return success to its caller, but in fact it should return -EOPNOTSUPP. Signed-off-by: Jisheng Zhang --- arch/arm/kernel/cpuidle.c |

[PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during init

2016-03-23 Thread Jisheng Zhang
Let's assume cpuidle_ops exists but it doesn't implement the according init member, current arm_cpuidle_init() will return success to its caller, but in fact it should return -EOPNOTSUPP. Signed-off-by: Jisheng Zhang --- arch/arm/kernel/cpuidle.c | 8 ++-- 1 file changed, 6 insertions(+), 2