On Thu, Nov 06, 2014 at 02:37:31PM +, Peter Rosin wrote:
> Mark Brown wrote:
> > > + if (tfa9879->lsb_justified)
> > > + TFA9879_REG(codec, SERIAL_INTERFACE_1, I2S_SET, i2s_set);
> > Why does this need to be reset every time, shouldn't we just be setting the
> > register in set_fmt().
Thanks for the review! I'm answering here, but would like to thank
Lars-Peter for the review as well.
Mark Brown wrote:
> On Thu, Nov 06, 2014 at 01:54:00PM +0100, Peter Rosin wrote:
>
> > +#define TFA9879_REG(codec, reg, field, value) \
> > + snd_soc_update_bits(codec, TFA9879_ ## reg,
On Thu, Nov 06, 2014 at 01:54:00PM +0100, Peter Rosin wrote:
> +#define TFA9879_REG(codec, reg, field, value)
> \
> + snd_soc_update_bits(codec, TFA9879_ ## reg, \
> + TFA9879_ ## field ## _MASK, \
> +
On 11/06/2014 01:54 PM, Peter Rosin wrote:
[...]
+#define TFA9879_REG(codec, reg, field, value) \
+ snd_soc_update_bits(codec, TFA9879_ ## reg, \
+ TFA9879_ ## field ## _MASK, \
+
From: Peter Rosin
Signed-off-by: Peter Rosin
---
MAINTAINERS|6 +
sound/soc/codecs/Kconfig |5 +
sound/soc/codecs/Makefile |2 +
sound/soc/codecs/tfa9879.c | 334
sound/soc/codecs/tfa9879.h | 202 +
5 matches
Mail list logo
