Re: [PATCH 1/2] Fix initialisation for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-26 Thread Jiri Kosina
On Fri, 23 Jan 2015, Benjamin Tissoires wrote: > With the changes above (or if you fix my typos), the patch is > Reviewed-by: Benjamin.tissoires > > Jiri, could you amend the commit with the above so that Jim won't be > desperate by submitting a patch? Done and applied this one. Jim, please mak

Re: [PATCH 1/2] Fix initialisation for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-23 Thread Benjamin Tissoires
You are missing here (before the first '---' the commit message which should state why you want to have this patch merged. To rephrase and continue what you wrote in your very first submission of this series, this could be (including your Signed-of-by): The FF2 driver (usbhid/hid-pidff.c) sends c

[PATCH 1/2] Fix initialisation for the Microsoft Sidewinder Force Feedback Pro 2 joystick

2015-01-23 Thread Jim Keir
--- Hi, Changes from previous patches: - All changes removed from higher-level files - Calls to hid_device_io_start/stop added here Signed-off-by: Jim Keir drivers/hid/usbhid/hid-pidff.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usb