Re: [PATCH 1/2] Input: bcm-keypad: add device tree bindings

2015-02-26 Thread Scott Branden
Hi Dmitry, Thanks for the update of no need to change any of dt-binding prefixes. I just sent out a v2 patch addressing all of your other comments. On 15-02-23 09:49 AM, Dmitry Torokhov wrote: Hi Scott, On Sun, Feb 15, 2015 at 09:17:51PM -0800, Dmitry Torokhov wrote: On Sat, Feb 14, 2015

Re: [PATCH 1/2] Input: bcm-keypad: add device tree bindings

2015-02-26 Thread Scott Branden
Hi Dmitry, Thanks for the update of no need to change any of dt-binding prefixes. I just sent out a v2 patch addressing all of your other comments. On 15-02-23 09:49 AM, Dmitry Torokhov wrote: Hi Scott, On Sun, Feb 15, 2015 at 09:17:51PM -0800, Dmitry Torokhov wrote: On Sat, Feb 14, 2015

Re: [PATCH 1/2] Input: bcm-keypad: add device tree bindings

2015-02-23 Thread Dmitry Torokhov
Hi Scott, On Sun, Feb 15, 2015 at 09:17:51PM -0800, Dmitry Torokhov wrote: > On Sat, Feb 14, 2015 at 08:49:15AM -0800, Scott Branden wrote: > > On 15-02-09 04:51 PM, Dmitry Torokhov wrote: > > >On Mon, Feb 09, 2015 at 04:07:40PM -0800, Scott Branden wrote: > > >>+ > > >>+-

Re: [PATCH 1/2] Input: bcm-keypad: add device tree bindings

2015-02-23 Thread Dmitry Torokhov
Hi Scott, On Sun, Feb 15, 2015 at 09:17:51PM -0800, Dmitry Torokhov wrote: On Sat, Feb 14, 2015 at 08:49:15AM -0800, Scott Branden wrote: On 15-02-09 04:51 PM, Dmitry Torokhov wrote: On Mon, Feb 09, 2015 at 04:07:40PM -0800, Scott Branden wrote: + +- col-debounce-filter-period: The

Re: [PATCH 1/2] Input: bcm-keypad: add device tree bindings

2015-02-15 Thread Dmitry Torokhov
Hi Scott, On Sat, Feb 14, 2015 at 08:49:15AM -0800, Scott Branden wrote: > Hi Dmitry, > > Comments inline. I still have an issue with vendor prefix as there > are not documented guidelines I can find in this area? I looked and I could not locate it written down either. I think Grant is in

Re: [PATCH 1/2] Input: bcm-keypad: add device tree bindings

2015-02-15 Thread Dmitry Torokhov
Hi Scott, On Sat, Feb 14, 2015 at 08:49:15AM -0800, Scott Branden wrote: Hi Dmitry, Comments inline. I still have an issue with vendor prefix as there are not documented guidelines I can find in this area? I looked and I could not locate it written down either. I think Grant is in Santa

Re: [PATCH 1/2] Input: bcm-keypad: add device tree bindings

2015-02-14 Thread Scott Branden
Hi Dmitry, Comments inline. I still have an issue with vendor prefix as there are not documented guidelines I can find in this area? On 15-02-09 04:51 PM, Dmitry Torokhov wrote: Hi Scott, On Mon, Feb 09, 2015 at 04:07:40PM -0800, Scott Branden wrote: Documents the Broadcom keypad

Re: [PATCH 1/2] Input: bcm-keypad: add device tree bindings

2015-02-14 Thread Scott Branden
Hi Dmitry, Comments inline. I still have an issue with vendor prefix as there are not documented guidelines I can find in this area? On 15-02-09 04:51 PM, Dmitry Torokhov wrote: Hi Scott, On Mon, Feb 09, 2015 at 04:07:40PM -0800, Scott Branden wrote: Documents the Broadcom keypad

Re: [PATCH 1/2] Input: bcm-keypad: add device tree bindings

2015-02-09 Thread Dmitry Torokhov
Hi Scott, On Mon, Feb 09, 2015 at 04:07:40PM -0800, Scott Branden wrote: > Documents the Broadcom keypad controller device tree bindings. > > Reviewed-by: Ray Jui > Signed-off-by: Scott Branden > --- > .../devicetree/bindings/input/brcm,bcm-keypad.txt | 118 > + > 1 file

[PATCH 1/2] Input: bcm-keypad: add device tree bindings

2015-02-09 Thread Scott Branden
Documents the Broadcom keypad controller device tree bindings. Reviewed-by: Ray Jui Signed-off-by: Scott Branden --- .../devicetree/bindings/input/brcm,bcm-keypad.txt | 118 + 1 file changed, 118 insertions(+) create mode 100644

Re: [PATCH 1/2] Input: bcm-keypad: add device tree bindings

2015-02-09 Thread Dmitry Torokhov
Hi Scott, On Mon, Feb 09, 2015 at 04:07:40PM -0800, Scott Branden wrote: Documents the Broadcom keypad controller device tree bindings. Reviewed-by: Ray Jui r...@broadcom.com Signed-off-by: Scott Branden sbran...@broadcom.com --- .../devicetree/bindings/input/brcm,bcm-keypad.txt | 118

[PATCH 1/2] Input: bcm-keypad: add device tree bindings

2015-02-09 Thread Scott Branden
Documents the Broadcom keypad controller device tree bindings. Reviewed-by: Ray Jui r...@broadcom.com Signed-off-by: Scott Branden sbran...@broadcom.com --- .../devicetree/bindings/input/brcm,bcm-keypad.txt | 118 + 1 file changed, 118 insertions(+) create mode 100644