Re: [PATCH 1/2] Input: rotary_encoder - Support key events

2019-01-06 Thread Dmitry Torokhov
On Sat, Jan 5, 2019 at 9:36 PM nazgul33 wrote: > > input_sync() is there, at the end of the function. I know. Nonetheless, you need another one between sending distinct key events. Userspace is allowed to accumulate device state until EV_SYN/SYN_REPORT is received, which can result in your key

Re: [PATCH 1/2] Input: rotary_encoder - Support key events

2019-01-05 Thread nazgul33
input_sync() is there, at the end of the function. static void rotary_encoder_report_event(struct rotary_encoder *encoder) { if (encoder->relative_axis) { input_report_rel(encoder->input, encoder->axis, encoder->dir); } else if (encoder->relative_keys) { u32

Re: [PATCH 1/2] Input: rotary_encoder - Support key events

2019-01-05 Thread Dmitry Torokhov
On Sat, Jan 5, 2019 at 2:27 PM Donghoon Han wrote: > > From: Steven Han > > Support generating EV_KEY pair, instead of EV_REL. > > Signed-off-by: Donghoon Han > --- > drivers/input/misc/rotary_encoder.c | 23 +-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff

[PATCH 1/2] Input: rotary_encoder - Support key events

2019-01-05 Thread Donghoon Han
From: Steven Han Support generating EV_KEY pair, instead of EV_REL. Signed-off-by: Donghoon Han --- drivers/input/misc/rotary_encoder.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/input/misc/rotary_encoder.c