Re: [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs

2019-06-13 Thread Aaron Ma
On 6/12/19 1:35 AM, Dmitry Torokhov wrote: > On Tue, Jun 11, 2019 at 12:55:58AM +0800, Aaron Ma wrote: >> On 6/10/19 12:55 AM, Dmitry Torokhov wrote: >>> Hi Aaron, >>> >>> On Wed, Feb 20, 2019 at 05:41:59PM +0100, Aaron Ma wrote: rmi4 got spam data after S3 resume on some ThinkPads. Then

Re: [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs

2019-06-11 Thread Dmitry Torokhov
On Tue, Jun 11, 2019 at 12:55:58AM +0800, Aaron Ma wrote: > > On 6/10/19 12:55 AM, Dmitry Torokhov wrote: > > Hi Aaron, > > > > On Wed, Feb 20, 2019 at 05:41:59PM +0100, Aaron Ma wrote: > >> rmi4 got spam data after S3 resume on some ThinkPads. > >> Then TrackPoint lost when be detected by

Re: [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs

2019-06-10 Thread Aaron Ma
On 6/10/19 12:55 AM, Dmitry Torokhov wrote: > Hi Aaron, > > On Wed, Feb 20, 2019 at 05:41:59PM +0100, Aaron Ma wrote: >> rmi4 got spam data after S3 resume on some ThinkPads. >> Then TrackPoint lost when be detected by psmouse. >> Clear irqs status before set irqs will make TrackPoint back. >

Re: [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs

2019-06-09 Thread Dmitry Torokhov
Hi Aaron, On Wed, Feb 20, 2019 at 05:41:59PM +0100, Aaron Ma wrote: > rmi4 got spam data after S3 resume on some ThinkPads. > Then TrackPoint lost when be detected by psmouse. > Clear irqs status before set irqs will make TrackPoint back. Could you please give me an idea as to what this spam

Re: [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs

2019-06-07 Thread Aaron Ma
Hi Dmitry: Will you apply them? Thanks, Aaron On 6/4/19 1:19 PM, Christopher Heiny wrote: > Given that, I'm willing to accept the patch as is. > > Cheers, > Chris

Re: [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs

2019-06-03 Thread Christopher Heiny
On Tue, 2019-06-04 at 10:45 +0800, Aaron Ma wrote: > Hi Christopher: > > Have got time to review these 2 patches? > Users reported it works fine since I sent out this patch. Hi Aaron, I've been poking around with this off and on. Unfortunately, more off than on :-( but here's my current take:

Re: [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs

2019-06-03 Thread Aaron Ma
Hi Christopher: Have got time to review these 2 patches? Users reported it works fine since I sent out this patch. Thanks, Aaron On 4/3/19 9:58 PM, Aaron Ma wrote: > Sure, take your time, if you have any questions let me know please. > > Thanks, > Aaron

Re: [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs

2019-04-03 Thread Aaron Ma
On 4/3/19 12:16 AM, Christopher Heiny wrote: > On Thu, 2019-03-28 at 14:02 +0800, Aaron Ma wrote: >> Hi Dmitry and Chiristopher: >> >> Do you have any suggestion about these 2 patches? >> >> Many users confirmed that they fixed issues of Trackpoint/Touchpad >> after S3. >> >> Will you consider

Re: [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs

2019-04-02 Thread Christopher Heiny
On Thu, 2019-03-28 at 14:02 +0800, Aaron Ma wrote: > Hi Dmitry and Chiristopher: > > Do you have any suggestion about these 2 patches? > > Many users confirmed that they fixed issues of Trackpoint/Touchpad > after S3. > > Will you consider them be accepted? Hi Aaron, Sorry - I thought I'd

Re: [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs

2019-03-28 Thread Aaron Ma
Hi Dmitry and Chiristopher: Do you have any suggestion about these 2 patches? Many users confirmed that they fixed issues of Trackpoint/Touchpad after S3. Will you consider them be accepted? Thanks, Aaron

Re: [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs

2019-03-09 Thread Aaron Ma
Hi, On 3/9/19 7:13 AM, Christopher Heiny wrote: > I'm not sure this is a safe action, due to a race condition with the > actual IRQ handler (rmi_process_interrupt_requests from rmi_driver.c). > Remember that reading the IRQ status register clears all the IRQ bits. > So you're faced with this

Re: [PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs

2019-03-08 Thread Christopher Heiny
On Wed, 2019-02-20 at 17:41 +0100, Aaron Ma wrote: > CAUTION: Email originated externally, do not click links or open > attachments unless you recognize the sender and know the content is > safe. > > > rmi4 got spam data after S3 resume on some ThinkPads. > Then TrackPoint lost when be detected

[PATCH 1/2] Input: synaptics-rmi4 - clear irqs before set irqs

2019-02-20 Thread Aaron Ma
rmi4 got spam data after S3 resume on some ThinkPads. Then TrackPoint lost when be detected by psmouse. Clear irqs status before set irqs will make TrackPoint back. BugLink: https://bugs.launchpad.net/bugs/1791427 Cc: Signed-off-by: Aaron Ma --- drivers/input/rmi4/rmi_driver.c | 11 +++