Re: [PATCH 1/2] KVM: selftests: Implement ucall() for s390x

2019-07-31 Thread Andrew Jones
On Wed, Jul 31, 2019 at 02:57:38PM +0200, Paolo Bonzini wrote: > On 31/07/19 13:16, Thomas Huth wrote: > > Or maybe even better: Let's move this file into lib/x86_64/ and > > lib/aarch64/ instead, since there is more different code between the > > architectures here than common code. > > All good

Re: [PATCH 1/2] KVM: selftests: Implement ucall() for s390x

2019-07-31 Thread Paolo Bonzini
On 31/07/19 13:16, Thomas Huth wrote: > Or maybe even better: Let's move this file into lib/x86_64/ and > lib/aarch64/ instead, since there is more different code between the > architectures here than common code. All good solutions, just choose one. :)) Paolo

Re: [PATCH 1/2] KVM: selftests: Implement ucall() for s390x

2019-07-31 Thread Thomas Huth
On 31/07/2019 12.28, Andrew Jones wrote: > On Wed, Jul 31, 2019 at 11:43:16AM +0200, Thomas Huth wrote: >> On 30/07/2019 12.48, Andrew Jones wrote: >>> On Tue, Jul 30, 2019 at 12:01:11PM +0200, Thomas Huth wrote: On s390x, we can neither exit via PIO nor MMIO, but have to use an

Re: [PATCH 1/2] KVM: selftests: Implement ucall() for s390x

2019-07-31 Thread Andrew Jones
On Wed, Jul 31, 2019 at 11:43:16AM +0200, Thomas Huth wrote: > On 30/07/2019 12.48, Andrew Jones wrote: > > On Tue, Jul 30, 2019 at 12:01:11PM +0200, Thomas Huth wrote: > >> On s390x, we can neither exit via PIO nor MMIO, but have to use > >> an instruction like DIAGNOSE. While we're at it, rename

Re: [PATCH 1/2] KVM: selftests: Implement ucall() for s390x

2019-07-31 Thread Thomas Huth
On 30/07/2019 12.48, Andrew Jones wrote: > On Tue, Jul 30, 2019 at 12:01:11PM +0200, Thomas Huth wrote: >> On s390x, we can neither exit via PIO nor MMIO, but have to use >> an instruction like DIAGNOSE. While we're at it, rename UCALL_PIO >> to UCALL_DEFAULT, since PIO only works on x86 anyway,

Re: [PATCH 1/2] KVM: selftests: Implement ucall() for s390x

2019-07-30 Thread Andrew Jones
On Tue, Jul 30, 2019 at 12:01:11PM +0200, Thomas Huth wrote: > On s390x, we can neither exit via PIO nor MMIO, but have to use > an instruction like DIAGNOSE. While we're at it, rename UCALL_PIO > to UCALL_DEFAULT, since PIO only works on x86 anyway, and this > way we can re-use the "default" type

[PATCH 1/2] KVM: selftests: Implement ucall() for s390x

2019-07-30 Thread Thomas Huth
On s390x, we can neither exit via PIO nor MMIO, but have to use an instruction like DIAGNOSE. While we're at it, rename UCALL_PIO to UCALL_DEFAULT, since PIO only works on x86 anyway, and this way we can re-use the "default" type for the DIAGNOSE exit on s390x. Now that ucall() is implemented, we