Re: [PATCH 1/2] PM / OPP: Use list_for_each_entry_reverse instead of list_for_each_entry

2014-04-29 Thread Viresh Kumar
On 29 April 2014 11:20, Jonghwan Choi wrote: > -> You are right. But 5440 cpufreq driver write an index number instead of > clk divider value > for change DVFS. And our another(will submit) also write an index number for > changing DVFS. > As you said, order of table shouldn't matter at all in

Re: [PATCH 1/2] PM / OPP: Use list_for_each_entry_reverse instead of list_for_each_entry

2014-04-29 Thread Viresh Kumar
On 29 April 2014 11:20, Jonghwan Choi jhbird.c...@samsung.com wrote: - You are right. But 5440 cpufreq driver write an index number instead of clk divider value for change DVFS. And our another(will submit) also write an index number for changing DVFS. As you said, order of table shouldn't

RE: [PATCH 1/2] PM / OPP: Use list_for_each_entry_reverse instead of list_for_each_entry

2014-04-28 Thread Jonghwan Choi
gmail.com [mailto:viresh.li...@gmail.com] On Behalf Of > Viresh Kumar > Sent: Tuesday, April 29, 2014 2:33 PM > To: Jonghwan Choi > Cc: open list; Rafael J. Wysocki; Len Brown > Subject: Re: [PATCH 1/2] PM / OPP: Use list_for_each_entry_reverse instead > of list_for_each_entry &g

Re: [PATCH 1/2] PM / OPP: Use list_for_each_entry_reverse instead of list_for_each_entry

2014-04-28 Thread Viresh Kumar
On Tue, Apr 29, 2014 at 10:54 AM, Jonghwan Choi wrote: > Most of the cpufreq table is sorted in descending order. Which part of kernel says that? > But when cpufreq table is made from dev_pm_opp_init_cpufreq_table, > it is sorted in ascending order. So in some case to make cpufreq table > with

[PATCH 1/2] PM / OPP: Use list_for_each_entry_reverse instead of list_for_each_entry

2014-04-28 Thread Jonghwan Choi
Most of the cpufreq table is sorted in descending order. But when cpufreq table is made from dev_pm_opp_init_cpufreq_table, it is sorted in ascending order. So in some case to make cpufreq table with descending order it needs an extra work. Signed-off-by: Jonghwan Choi ---

[PATCH 1/2] PM / OPP: Use list_for_each_entry_reverse instead of list_for_each_entry

2014-04-28 Thread Jonghwan Choi
Most of the cpufreq table is sorted in descending order. But when cpufreq table is made from dev_pm_opp_init_cpufreq_table, it is sorted in ascending order. So in some case to make cpufreq table with descending order it needs an extra work. Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com ---

Re: [PATCH 1/2] PM / OPP: Use list_for_each_entry_reverse instead of list_for_each_entry

2014-04-28 Thread Viresh Kumar
On Tue, Apr 29, 2014 at 10:54 AM, Jonghwan Choi jhbird.c...@samsung.com wrote: Most of the cpufreq table is sorted in descending order. Which part of kernel says that? But when cpufreq table is made from dev_pm_opp_init_cpufreq_table, it is sorted in ascending order. So in some case to make

RE: [PATCH 1/2] PM / OPP: Use list_for_each_entry_reverse instead of list_for_each_entry

2014-04-28 Thread Jonghwan Choi
: Tuesday, April 29, 2014 2:33 PM To: Jonghwan Choi Cc: open list; Rafael J. Wysocki; Len Brown Subject: Re: [PATCH 1/2] PM / OPP: Use list_for_each_entry_reverse instead of list_for_each_entry On Tue, Apr 29, 2014 at 10:54 AM, Jonghwan Choi jhbird.c...@samsung.com wrote: Most of the cpufreq